runtime/vm/dart_api_impl.cc - Issue 11418004: Don't copy Int8Arrays when passing them in as lists of bytes and don't

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 11418004: Don't copy Int8Arrays when passing them in as lists of bytes and don't (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index 55c436ad034d0190c97334565f8519d06bd8880d..fb992035d27d509583377477b25f7cb44354c09a 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -1950,7 +1950,8 @@ DART_EXPORT Dart_Handle Dart_ListGetAsBytes(Dart_Handle list,

Isolate* isolate = Isolate::Current();

DARTSCOPE(isolate);

const Object& obj = Object::Handle(isolate, Api::UnwrapHandle(list));

- if (obj.IsUint8Array() || obj.IsExternalUint8Array()) {

+ if (obj.IsUint8Array() || obj.IsExternalUint8Array() ||

+ obj.IsInt8Array() || obj.IsExternalInt8Array()) {

const ByteArray& byte_array = ByteArray::Cast(obj);

if (Utils::RangeCheck(offset, length, byte_array.Length())) {

ByteArray::Copy(native_array, byte_array, offset, length);

« no previous file with comments | « no previous file | sdk/lib/io/common.dart » ('j') | no next file with comments »