sdk/lib/utf/utf16.dart - Issue 11416240: Address Ivan's comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/utf/utf16.dart

Issue 11416240: Address Ivan's comments. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart

Patch Set: Fix typos Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/utf/utf16.dart

diff --git a/sdk/lib/utf/utf16.dart b/sdk/lib/utf/utf16.dart

index 6d39d338489e5029d2710dd4fab9f5cd548c6a88..680d3de5eef3306307f7b4c00e78fe55dcad0606 100644

--- a/sdk/lib/utf/utf16.dart

+++ b/sdk/lib/utf/utf16.dart

@@ -215,6 +215,8 @@ typedef _ListRangeIterator _CodeUnitsProvider();

* provides an iterator on demand and the iterator will only translate bytes

* as requested by the user of the iterator. (Note: results are not cached.)

+// TODO(floitsch): Consider removing the extend and switch to implements since

+// that's cheaper to allocate.

class IterableUtf16Decoder extends Iterable<int> {

final _CodeUnitsProvider codeunitsProvider;

final int replacementCodepoint;

« no previous file with comments | « sdk/lib/isolate/base.dart ('k') | sdk/lib/utf/utf32.dart » ('j') | no next file with comments »