Issue 7128. Don't show problems in dart:core

Issue 7128. Don't show problems in dart:core


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=15701

[Brian Wilkerson, 2012-12-04 19:14:14]

LGTM

https://codereview.chromium.org/11415291/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
(right):

https://codereview.chromium.org/11415291/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/DartCompilerMainContext.java:61: if
(Elements.isCoreLibrarySource(event.getSource())) {
Hm. I thought we had a request from the core library team to *not* hide these
errors. Am I mis-remembering? If not, perhaps we need a command-line flag to
control it (defaulting, I would guess, to hide such errors).

[scheglov, 2012-12-04 19:42:15]

https://codereview.chromium.org/11415291/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
(right):

https://codereview.chromium.org/11415291/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/DartCompilerMainContext.java:61: if
(Elements.isCoreLibrarySource(event.getSource())) {
On 2012/12/04 19:14:15, Brian Wilkerson wrote:
> Hm. I thought we had a request from the core library team to *not* hide these
> errors. Am I mis-remembering? If not, perhaps we need a command-line flag to
> control it (defaulting, I would guess, to hide such errors).

We show the same problems like "Expected constant expression of type num, got
int", when we analyze from Editor and from comment line. So, there are no much
reasons to show them anywhere.