Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: compiler/java/com/google/dart/compiler/DartCompilerMainContext.java

Issue 11415291: Issue 7128. Don't show problems in dart:core (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
diff --git a/compiler/java/com/google/dart/compiler/DartCompilerMainContext.java b/compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
index 4643e1cbb4496ba58f66197f0d93682eb29cc4c8..d45c00debc20c97e9989d79cf3096e087d45f973 100644
--- a/compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
+++ b/compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
@@ -11,6 +11,7 @@ import com.google.dart.compiler.ast.DartUnit;
import com.google.dart.compiler.ast.LibraryUnit;
import com.google.dart.compiler.metrics.CompilerMetrics;
import com.google.dart.compiler.parser.DartParser;
+import com.google.dart.compiler.resolver.Elements;
import java.io.IOException;
import java.io.Reader;
@@ -55,6 +56,12 @@ final class DartCompilerMainContext implements DartCompilerListener, DartCompile
@Override
public void onError(DartCompilationError event) {
+ // problems in dart:core are not interesting
+ // http://code.google.com/p/dart/issues/detail?id=7128
+ if (Elements.isCoreLibrarySource(event.getSource())) {
Brian Wilkerson 2012/12/04 19:14:15 Hm. I thought we had a request from the core libra
scheglov 2012/12/04 19:42:15 We show the same problems like "Expected constant
+ return;
+ }
+
// Remember error.
{
Source source = event.getSource();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698