Issue 11414029: At SSA build-time, change the block information that we attach to loop with aborting bodies.

Issue 11414029: At SSA build-time, change the block information that we attach to loop with aborting bodies. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org, ahe, kasperl, karlklose, Johnni Winther

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

At SSA build-time, change the block information that we attach to loop with aborting bodies. Committed: https://code.google.com/p/dart/source/detail?r=15031

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -42 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	3 chunks	+115 lines, -36 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/11414029/diff/3001/sdk/lib/_internal/compiler/implementation/elements/elements.dart File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/11414029/diff/3001/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode1943 sdk/lib/_internal/compiler/implementation/elements/elements.dart:1943: ElementKind.LABEL, So you can have a LabelElement without ...

8 years, 1 month ago (2012-11-16 15:09:11 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-16 16:45:27 UTC) #3

Thanks Lasse.

https://codereview.chromium.org/11414029/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):

https://codereview.chromium.org/11414029/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:1943:
ElementKind.LABEL,
On 2012/11/16 15:09:11, Lasse Reichstein Nielsen wrote:
> So you can have a LabelElement without a Label?
> Is this for synthetic labels? 
> Do add a comment.

Done.

https://codereview.chromium.org/11414029/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11414029/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1804: void
initialize(),
On 2012/11/16 15:09:11, Lasse Reichstein Nielsen wrote:
> Is this tabs?

No.

https://codereview.chromium.org/11414029/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1933: // } else {
On 2012/11/16 15:09:11, Lasse Reichstein Nielsen wrote:
> Explain the empty else block.

Done.

https://codereview.chromium.org/11414029/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1936: // If there is
any break in the body, we attach a synthesized
On 2012/11/16 15:09:11, Lasse Reichstein Nielsen wrote:
> I prefer "synthetic".

Done.

https://codereview.chromium.org/11414029/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2142: LabelElement
label = target.addLabel(null, 'doWhile');
On 2012/11/16 15:09:11, Lasse Reichstein Nielsen wrote:
> This label is "doWhile" and the other one was "loop" (I can see it can't be
> "while" but try to do something consistent, e.g., "loop" in both cases).

Done.

Expand Messages | Collapse Messages