Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 11414029: At SSA build-time, change the block information that we attach to loop with aborting bodies. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 15009)
+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)
@@ -831,7 +831,7 @@
bool visitLoopInfo(HLoopBlockInformation info) {
HExpressionInformation condition = info.condition;
- bool isConditionExpression = condition == null || isJSCondition(condition);
+ bool isConditionExpression = isJSCondition(condition);
js.Loop loop;
@@ -962,9 +962,7 @@
if (info.updates != null) {
generateStatements(info.updates);
}
- if (condition == null) {
- push(newLiteralBool(false));
- } else if (isConditionExpression) {
+ if (isConditionExpression) {
push(generateExpression(condition));
} else {
generateStatements(condition);
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698