Issue 11413053: Remove _NodeListWrapper, make NodeList less special.

Issue 11413053: Remove _NodeListWrapper, make NodeList less special. (Closed)

Created:
8 years, 1 month ago by sra1

Modified:
8 years, 1 month ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org, podivilov1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove _NodeListWrapper, make NodeList less special. Committed: https://code.google.com/p/dart/source/detail?r=15054

Patch Set 1 #

Total comments: 4

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+232 lines, -602 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	5 chunks	+102 lines, -189 lines	1 comment	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	5 chunks	+108 lines, -192 lines	0 comments	Download
M	sdk/lib/html/scripts/generator.py	View	3 chunks	+2 lines, -9 lines	1 comment	Download
M	sdk/lib/html/scripts/systemhtml.py	View	1 chunk	+12 lines, -17 lines	0 comments	Download
M	sdk/lib/html/scripts/systemnative.py	View	1 chunk	+6 lines, -14 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Node.darttemplate	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	sdk/lib/html/templates/html/impl/impl_NodeList.darttemplate	View	1 chunk	+0 lines, -179 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

https://codereview.chromium.org/11413053/diff/1/sdk/lib/html/templates/html/impl/impl_NodeList.darttemplate File sdk/lib/html/templates/html/impl/impl_NodeList.darttemplate (left): https://codereview.chromium.org/11413053/diff/1/sdk/lib/html/templates/html/impl/impl_NodeList.darttemplate#oldcode87 sdk/lib/html/templates/html/impl/impl_NodeList.darttemplate:87: Node _parent; All this stuff with _parent is bogus. ...

8 years, 1 month ago (2012-11-17 02:30:11 UTC) #1

Emily Fortuna

8 years, 1 month ago (2012-11-17 02:44:30 UTC) #2

lgtm, one question

https://codereview.chromium.org/11413053/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11413053/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:15431: class RadioNodeList extends
_NodeList native "*RadioNodeList" {
is it an issue at all that it's extending a hidden class?

https://codereview.chromium.org/11413053/diff/1/sdk/lib/html/scripts/generato...
File sdk/lib/html/scripts/generator.py (left):

https://codereview.chromium.org/11413053/diff/1/sdk/lib/html/scripts/generato...
sdk/lib/html/scripts/generator.py:708: # TODO(podivilov): why NodeList is
special?
woohoo!

https://codereview.chromium.org/11413053/diff/1/sdk/lib/html/templates/html/i...
File sdk/lib/html/templates/html/impl/impl_NodeList.darttemplate (left):

https://codereview.chromium.org/11413053/diff/1/sdk/lib/html/templates/html/i...
sdk/lib/html/templates/html/impl/impl_NodeList.darttemplate:87: Node _parent;
On 2012/11/17 02:30:11, sra1 wrote:
> All this stuff with _parent is bogus.
> _parent was never set.
> The magic version of NodeList is _ChildNodeListLazy.

awesome :-P

Expand Messages | Collapse Messages