Issue 11412147: Fix a type annotation in the parser to make it accept non-literal strings as part URIs in checked m…

Issue 11412147: Fix a type annotation in the parser to make it accept non-literal strings as part URIs in checked m… (Closed)

Created:
8 years, 1 month ago by karlklose

Modified:
8 years, 1 month ago

Reviewers:
ahe

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a type annotation in the parser to make it accept non-literal strings as part URIs in checked mode. Committed: https://code.google.com/p/dart/source/detail?r=15259

Patch Set 2 : Also fix import and add a test. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -18 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/tree/nodes.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A +	tests/language/library_juxtaposition_lib.dart	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
A +	tests/language/library_juxtaposition_part.dart	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
A +	tests/language/library_juxtaposition_test.dart	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/11412147/diff/1/sdk/lib/_internal/compiler/implementation/tree/nodes.dart File sdk/lib/_internal/compiler/implementation/tree/nodes.dart (right): https://codereview.chromium.org/11412147/diff/1/sdk/lib/_internal/compiler/implementation/tree/nodes.dart#newcode1687 sdk/lib/_internal/compiler/implementation/tree/nodes.dart:1687: final LiteralString uri; What about this one?

8 years, 1 month ago (2012-11-22 12:13:37 UTC) #2

karlklose

I also added a test. https://codereview.chromium.org/11412147/diff/1/sdk/lib/_internal/compiler/implementation/tree/nodes.dart File sdk/lib/_internal/compiler/implementation/tree/nodes.dart (right): https://codereview.chromium.org/11412147/diff/1/sdk/lib/_internal/compiler/implementation/tree/nodes.dart#newcode1687 sdk/lib/_internal/compiler/implementation/tree/nodes.dart:1687: final LiteralString uri; On ...

8 years, 1 month ago (2012-11-22 13:35:04 UTC) #3

LGTM!

Expand Messages | Collapse Messages