Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: sdk/lib/_internal/compiler/implementation/scanner/listener.dart

Issue 11412147: Fix a type annotation in the parser to make it accept non-literal strings as part URIs in checked m… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Also fix import and add a test. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/tree/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/scanner/listener.dart
diff --git a/sdk/lib/_internal/compiler/implementation/scanner/listener.dart b/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
index 783be1ce0aab47f07f517ba3a52a39943d80c74d..e8a15aa55ec01b7b5cc34e3ef5487a1c173f47f6 100644
--- a/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
+++ b/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
@@ -641,7 +641,7 @@ class ElementListener extends Listener {
return result;
}
- LiteralString popLiteralString() {
+ StringNode popLiteralString() {
StringNode node = popNode();
// TODO(lrn): Handle interpolations in script tags.
if (node.isInterpolation) {
@@ -671,7 +671,7 @@ class ElementListener extends Listener {
if (asKeyword != null) {
prefix = popNode();
}
- LiteralString uri = popLiteralString();
+ StringNode uri = popLiteralString();
addLibraryTag(new Import(importKeyword, uri, prefix, combinators));
}
@@ -703,7 +703,7 @@ class ElementListener extends Listener {
}
void endPart(Token partKeyword, Token semicolon) {
- LiteralString uri = popLiteralString();
+ StringNode uri = popLiteralString();
addLibraryTag(new Part(partKeyword, uri));
}
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/tree/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698