Issue 11412137: Reenable function source fingerprint checks. Added checks to MethodRecognizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412137: Reenable function source fingerprint checks. Added checks to MethodRecognizer. (Closed)

Created:
8 years, 1 month ago by srdjan

Modified:
8 years, 1 month ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Reenable function source fingerprint checks. Added checks to MethodRecognizer. Committed: https://code.google.com/p/dart/source/detail?r=15230

Patch Set 3 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -29 lines)			Patch
M	runtime/vm/intermediate_language.h	View	1	2 chunks	+14 lines, -12 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier.cc	View	1 2	2 chunks	+1 line, -14 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	1 chunk	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM with one comment. https://codereview.chromium.org/11412137/diff/2002/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/11412137/diff/2002/runtime/vm/intermediate_language.cc#newcode240 runtime/vm/intermediate_language.cc:240: } We could make this ...

8 years, 1 month ago (2012-11-21 22:02:50 UTC) #2

srdjan

8 years, 1 month ago (2012-11-21 22:10:36 UTC) #3

Thanks.

https://codereview.chromium.org/11412137/diff/2002/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/11412137/diff/2002/runtime/vm/intermediate_la...
runtime/vm/intermediate_language.cc:240: }
On 2012/11/21 22:02:50, siva wrote:
> We could make this a static function in class Function
> that way you don't have to repeat it twice and you would
> invoke it as function.CheckFingerprint(fp) below.

Done.

Expand Messages | Collapse Messages

Issue 11412137: Reenable function source fingerprint checks. Added checks to MethodRecognizer. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages