Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: runtime/vm/intrinsifier.cc

Issue 11412137: Reenable function source fingerprint checks. Added checks to MethodRecognizer. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier.cc
===================================================================
--- runtime/vm/intrinsifier.cc (revision 15218)
+++ runtime/vm/intrinsifier.cc (working copy)
@@ -94,19 +94,6 @@
}
-static bool CheckFingerprint(const Function& function, intptr_t fp) {
- /*if (function.SourceFingerprint() != fp) {
- OS::Print("FP mismatch while intrinsifying %s:"
- " expecting %"Pd" found %d\n",
- function.ToFullyQualifiedCString(),
- fp,
- function.SourceFingerprint());
- return true;
- } */
- return true;
-}
-
-
bool Intrinsifier::Intrinsify(const Function& function, Assembler* assembler) {
if (!CanIntrinsify(function)) return false;
const char* function_name = String::Handle(function.name()).ToCString();
@@ -116,7 +103,7 @@
if (TestFunction(function, \
class_name, function_name, \
#test_class_name, #test_function_name)) { \
- ASSERT(CheckFingerprint(function, fp)); \
+ ASSERT(function.CheckSourceFingerprint(fp)); \
return destination(assembler); \
} \
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698