Issue 11410016: Handle URLs in 'git clone' argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11410016: Handle URLs in 'git clone' argument. (Closed)

Created:
8 years, 1 month ago by Bob Nystrom

Modified:
8 years, 1 month ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle URLs in 'git clone' argument. Committed: https://code.google.com/p/dart/source/detail?r=14763

Patch Set 2 : Respond to review. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	utils/pub/git_source.dart	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

A couple notes on the RegExp, but otherwise LGTM. https://codereview.chromium.org/11410016/diff/1/utils/pub/git_source.dart File utils/pub/git_source.dart (right): https://codereview.chromium.org/11410016/diff/1/utils/pub/git_source.dart#newcode155 utils/pub/git_source.dart:155: ...

8 years, 1 month ago (2012-11-09 22:28:11 UTC) #2

Bob Nystrom

8 years, 1 month ago (2012-11-09 22:55:00 UTC) #3

https://codereview.chromium.org/11410016/diff/1/utils/pub/git_source.dart
File utils/pub/git_source.dart (right):

https://codereview.chromium.org/11410016/diff/1/utils/pub/git_source.dart#new...
utils/pub/git_source.dart:155: const URL_LIKE = const RegExp('[a-z]+\:');
On 2012/11/09 22:28:12, nweiz wrote:
> You should really use an r-string here, and it should start with "^". Also,
the
> colon doesn't need to be escaped.

Done, thanks!

Expand Messages | Collapse Messages

Issue 11410016: Handle URLs in 'git clone' argument. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Respond to review. #

Messages