Handle URLs in 'git clone' argument.

utils/pub/git_source.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library git_source;
 
 import 'git.dart' as git;
 import 'io.dart';
 import 'package.dart';
 import 'source.dart';
@@ skipping 132 matching lines @@
   /**
    * Clones the repo at the URI [from] to the path [to] on the local filesystem.
    *
    * If [mirror] is true, create a bare, mirrored clone. This doesn't check out
    * the working tree, but instead makes the repository a local mirror of the
    * remote repository. See the manpage for `git clone` for more information.
    */
   Future _clone(String from, String to, {bool mirror: false}) {
     // TODO(rnystrom): For some mysterious reason, the Windows buildbots do not
     // have the right working directory when pub spawns git, so the relative
-    // path fails. To work around it, just always pass in a full path. Should
-    // figure out what's going on here.
-    from = getFullPath(from);
+    // path fails. To work around it, if [from] looks like a relative path then
+    // manually make it absolute here. Should figure out what's really going on.
+    const URL_LIKE = const RegExp('[a-z]+\:');

[nweiz, 2012/11/09 22:28:12]

You should really use an r-string here, and it should start with "^". Also, the
colon doesn't need to be escaped.

[Bob Nystrom, 2012/11/09 22:55:00]

Done, thanks!

+    if (!URL_LIKE.hasMatch(from)) {
+      from = getFullPath(from);
+    }
 
     // Git on Windows does not seem to automatically create the destination
     // directory.
     return ensureDir(to).chain((_) {
       var args = ["clone", from, to];
       if (mirror) args.insertRange(1, 1, "--mirror");
       return git.run(args);
     }).transform((result) => null);
   }
 
@@ skipping 57 matching lines @@
 
   /**
    * Returns [description] if it's a description, or [PackageId.description] if
    * it's a [PackageId].
    */
   _getDescription(description) {
     if (description is PackageId) return description.description;
     return description;
   }
 }