Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1140313003: Create default tasks if plugins are not being used (Closed)

Created:
5 years, 7 months ago by Brian Wilkerson
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : sort #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 1 3 chunks +6 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 1 chunk +0 lines, -7 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 7 months ago (2015-05-19 21:05:05 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1140313003/diff/20001/pkg/analyzer/test/src/context/abstract_context.dart File pkg/analyzer/test/src/context/abstract_context.dart (left): https://codereview.chromium.org/1140313003/diff/20001/pkg/analyzer/test/src/context/abstract_context.dart#oldcode92 pkg/analyzer/test/src/context/abstract_context.dart:92: extensionManager.processPlugins([plugin]); I this case the "extensionManager" field is ...
5 years, 7 months ago (2015-05-19 21:09:25 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1140313003/diff/20001/pkg/analyzer/test/src/context/abstract_context.dart File pkg/analyzer/test/src/context/abstract_context.dart (left): https://codereview.chromium.org/1140313003/diff/20001/pkg/analyzer/test/src/context/abstract_context.dart#oldcode92 pkg/analyzer/test/src/context/abstract_context.dart:92: extensionManager.processPlugins([plugin]); Done. I also removed two unused imports.
5 years, 7 months ago (2015-05-19 21:12:09 UTC) #4
Brian Wilkerson
5 years, 7 months ago (2015-05-19 21:12:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0e8520eaa94920ec1e1b24e2ca41276861347687 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698