Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 1140313003: Create default tasks if plugins are not being used (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: sort Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index 05e6576e633a870f6e935587a05365eeef881666..a47215e27c6d5536f096800e668389fefec22852 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -7,9 +7,9 @@
library engine;
-import "dart:math" as math;
import 'dart:async';
import 'dart:collection';
+import 'dart:math' as math;
import 'package:analyzer/src/cancelable_future.dart';
import 'package:analyzer/src/context/cache.dart' as cache;
@@ -21,6 +21,7 @@ import 'package:analyzer/src/task/manager.dart';
import 'package:analyzer/src/task/task_dart.dart';
import 'package:analyzer/task/dart.dart';
import 'package:analyzer/task/model.dart';
+import 'package:plugin/manager.dart';
import '../../instrumentation/instrumentation.dart';
import 'ast.dart';
@@ -5769,6 +5770,10 @@ class AnalysisEngine {
*/
TaskManager get taskManager {
if (_taskManager == null) {
+ if (enginePlugin.taskExtensionPoint == null) {
+ // The plugin wasn't used, so tasks are not registered.
+ new ExtensionManager().processPlugins([enginePlugin]);
+ }
_taskManager = new TaskManager();
_taskManager.addTaskDescriptors(enginePlugin.taskDescriptors);
// TODO(brianwilkerson) Create a way to associate different results with

Powered by Google App Engine
This is Rietveld 408576698