Make copying from script insets omit line numbers and breakpoint indicators.

Make copying from script insets omit line numbers and breakpoint indicators.

Committed: https://code.google.com/p/dart/source/detail?r=45652

[rmacnak, 2015-05-07 21:13:45]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-05-07 22:58:17]

LGTMwC

https://codereview.chromium.org/1137523002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/script_inset.dart (right):

https://codereview.chromium.org/1137523002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/script_inset.dart:393: Timer.run(() {
This is Timer.run is a beautiful hack. Could we factor this into a utility
method to ObservatoryElement with some API docs?

https://codereview.chromium.org/1137523002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/script_inset.dart:489:
e.classes.add("possibleBreakpoint");
every branch adds the class, why not move it to the top of lineBreakpointElement
?

https://codereview.chromium.org/1137523002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/script_inset.dart:576:
e.append(span('\n'));
<br> ?

[rmacnak, 2015-05-08 19:58:19]

https://codereview.chromium.org/1137523002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/script_inset.dart (right):

https://codereview.chromium.org/1137523002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/script_inset.dart:393: Timer.run(() {
On 2015/05/07 22:58:17, Cutch wrote:
> This is Timer.run is a beautiful hack. Could we factor this into a utility
> method to ObservatoryElement with some API docs?

Extracted as makeCssClassUncopyable.

https://codereview.chromium.org/1137523002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/script_inset.dart:489:
e.classes.add("possibleBreakpoint");
On 2015/05/07 22:58:17, Cutch wrote:
> every branch adds the class, why not move it to the top of
lineBreakpointElement
> ?

Done.

https://codereview.chromium.org/1137523002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/script_inset.dart:576:
e.append(span('\n'));
On 2015/05/07 22:58:17, Cutch wrote:
> <br> ?

No, this is here so blank lines are included when you copy, not for formatting.
Added comment.

[rmacnak, 2015-05-08 19:58:36]

Committed patchset #2 (id:20001) manually as 45652 (presubmit successful).