Make copying from script insets omit line numbers and breakpoint indicators.

runtime/observatory/lib/src/elements/script_inset.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library script_inset_element;
 
 import 'dart:async';
 import 'dart:html';
 import 'observatory_element.dart';
 import 'service_ref.dart';
@@ skipping 364 matching lines @@
         annotations.add(new CallSiteAnnotation(callSite));
       }
     }
 
     annotations.sort();
   }
 
   Element linesTable() {
     var table = new DivElement();
     table.classes.add("sourceTable");
+    table.onCopy.listen((event) {
+      // Omit breakpoint indicators and line numbers when copying text by
+      // marking them as hidden before the copy happens, then marking them
+      // visible on the next event loop turn.
+      var noCopyNodes = shadowRoot.getElementsByClassName("noCopy");
+      for(var node in noCopyNodes) {
+        node.style.visibility = 'hidden';
+      }
+      Timer.run(() {

[Cutch, 2015/05/07 22:58:17]

This is Timer.run is a beautiful hack. Could we factor this into a utility
method to ObservatoryElement with some API docs?

[rmacnak, 2015/05/08 19:58:18]

Extracted as makeCssClassUncopyable.

+        for (var node in noCopyNodes) {
+          node.style.visibility = 'visible';
+        }
+      });
+    });
 
     annotationsCursor = 0;
 
     int blankLineCount = 0;
     for (int i = _startLine; i <= _endLine; i++) {
       var line = script.getLine(i);
       if (line.isBlank) {
         // Try to introduce elipses if there are 4 or more contiguous
         // blank lines.
         blankLineCount++;
@@ skipping 47 matching lines @@
     e.append(lineNumberElement(line));
     e.append(lineSourceElement(line));
     return e;
   }
 
   Element lineBreakpointElement(ScriptLine line) {
     var e = new DivElement();
     var busy = false;
     if (line == null || !line.possibleBpt) {
       e.classes.add("emptyBreakpoint");
+      e.classes.add('noCopy');
       e.text = nbsp;
       return e;
     }
     e.text = 'B';
     update() {
       if (busy) {
         e.classes.clear();
         e.classes.add("busyBreakpoint");
+        e.classes.add('noCopy');
       } else {
         if (line.breakpoints != null) {
           if (line.breakpointResolved) {
             e.classes.clear();
             e.classes.add("resolvedBreakpoint");
+            e.classes.add('noCopy');
           } else {
             e.classes.clear();
             e.classes.add("unresolvedBreakpoint");
+            e.classes.add('noCopy');
           }
         } else {
           e.classes.clear();
           e.classes.add("possibleBreakpoint");

[Cutch, 2015/05/07 22:58:17]

every branch adds the class, why not move it to the top of lineBreakpointElement
?

[rmacnak, 2015/05/08 19:58:18]

Done.

+          e.classes.add('noCopy');
         }
       }
     }
     line.changes.listen((_) => update());
     e.onClick.listen((event) {
       if (busy) {
         return;
       }
       busy = true;
       if (line.breakpoints == null) {
@@ skipping 15 matching lines @@
       }
       update();
     });
     update();
     return e;
   }
 
   Element lineNumberElement(ScriptLine line) {
     var lineNumber = line == null ? "..." : line.line;
     var e = span("$nbsp$lineNumber$nbsp");
+    e.classes.add('noCopy');
 
     if ((line == null) || (line.hits == null)) {
       hitsUnknown(e);
     } else if (line.hits == 0) {
       hitsNotExecuted(e);
     } else {
       hitsExecuted(e);
     }
 
     return e;
@@ skipping 29 matching lines @@
 
       // TODO(rmacnak): Tolerate overlapping annotations.
       var annotation;
       while ((annotation = nextAnnotationOnLine(line.line)) != null) {
         consumeUntil(annotation.columnStart);
         annotation.applyStyleTo(consumeUntil(annotation.columnStop));
       }
       consumeUntil(line.text.length);
     }
 
+    e.append(span('\n'));

[Cutch, 2015/05/07 22:58:17]

<br> ?

[rmacnak, 2015/05/08 19:58:18]

No, this is here so blank lines are included when you copy, not for formatting.
Added comment.

+
     return e;
   }
 
   ScriptInsetElement.created() : super.created();
 }