Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137233004: Make more use of ArgumentError.value in js_lib. (Closed)

Created:
5 years, 7 months ago by sra1
Modified:
5 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, Chris Bracken
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Make more use of ArgumentError.value in js_lib. This helps surface error values in the messages which helps make captured errors understandable. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=45782

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 8 chunks +26 lines, -26 lines 0 comments Download
M tests/corelib/errors_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sra1
5 years, 7 months ago (2015-05-13 02:34:16 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1137233004/diff/1/sdk/lib/_internal/compiler/js_lib/js_helper.dart File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right): https://codereview.chromium.org/1137233004/diff/1/sdk/lib/_internal/compiler/js_lib/js_helper.dart#newcode1411 sdk/lib/_internal/compiler/js_lib/js_helper.dart:1411: ArgumentError _ArgumentError(object) { it's a function. -> lower ...
5 years, 7 months ago (2015-05-13 05:11:29 UTC) #3
sra1
Committed patchset #2 (id:20001) manually as 45782 (presubmit successful).
5 years, 7 months ago (2015-05-13 22:16:58 UTC) #4
sra1
5 years, 7 months ago (2015-05-13 22:17:49 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1137233004/diff/1/sdk/lib/_internal/compiler/...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/1137233004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:1411: ArgumentError
_ArgumentError(object) {
On 2015/05/13 05:11:29, floitsch wrote:
> it's a function. -> lower case.
>  (even if it's to simulate a constructor call).

Done.

Powered by Google App Engine
This is Rietveld 408576698