Make more use of ArgumentError.value in js_lib.

sdk/lib/_internal/compiler/js_lib/js_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library _js_helper;
 
 import 'dart:_async_await_error_codes' as async_error_codes;
 
 import 'dart:_js_embedded_names' show
     DEFERRED_LIBRARY_URIS,
@@ skipping 176 matching lines @@
       return JS('String', r'"" + (#)', value);
     }
   } else if (true == value) {
     return 'true';
   } else if (false == value) {
     return 'false';
   } else if (value == null) {
     return 'null';
   }
   var res = value.toString();
-  if (res is !String) throw new ArgumentError(value);
+  if (res is !String) throw _ArgumentError(value);
   return res;
 }
 
 createInvocationMirror(String name, internalName, kind, arguments,
                        argumentNames) {
   return new JSInvocationMirror(name,
                                 internalName,
                                 kind,
                                 arguments,
                                 argumentNames);
@@ skipping 475 matching lines @@
         // Cannot fail because we know that the digits are all decimal.
         return JS('int', r'parseInt(#, 10)', source);
       }
       if (match[hexIndex] != null) {
         // Cannot fail because we know that the digits are all hex.
         return JS('int', r'parseInt(#, 16)', source);
       }
       return _parseIntError(source, handleError);
     }
 
-    if (radix is! int) throw new ArgumentError("Radix is not an integer");
+    if (radix is! int) {
+      throw new ArgumentError.value(radix, 'radix', 'is not an integer');
+    }
     if (radix < 2 || radix > 36) {
-      throw new RangeError.range(radix, 2, 36, "radix");
+      throw new RangeError.range(radix, 2, 36, 'radix');
     }
     if (radix == 10 && decimalMatch != null) {
       // Cannot fail because we know that the digits are all decimal.
       return JS('int', r'parseInt(#, 10)', source);
     }
     // If radix >= 10 and we have only decimal digits the string is safe.
     // Otherwise we need to check the digits.
     if (radix < 10 || decimalMatch == null) {
       // We know that the characters must be ASCII as otherwise the
       // regexp wouldn't have matched. Lowercasing by doing `| 0x20` is thus
@@ skipping 24 matching lines @@
     }
     // The above matching and checks ensures the source has at least one digits
     // and all digits are suitable for the radix, so parseInt cannot return NaN.
     return JS('int', r'parseInt(#, #)', source, radix);
   }
 
   @NoInline()
   static double _parseDoubleError(String source,
                                   double handleError(String source)) {
     if (handleError == null) {
-      throw new FormatException("Invalid double", source);
+      throw new FormatException('Invalid double', source);
     }
     return handleError(source);
   }
 
   static double parseDouble(String source, double handleError(String source)) {
     checkString(source);
     // Notice that JS parseFloat accepts garbage at the end of the string.
     // Accept only:
     // - [+/-]NaN
     // - [+/-]Infinity
@@ skipping 114 matching lines @@
       result = JS('String',
           r'# + String.fromCharCode.apply(null, #.slice(#, #))',
           result, array, i, chunkEnd);
     }
     return result;
   }
 
   static String stringFromCodePoints(codePoints) {
     List<int> a = <int>[];
     for (var i in codePoints) {
-      if (i is !int) throw new ArgumentError(i);
+      if (i is !int) throw _ArgumentError(i);
       if (i <= 0xffff) {
         a.add(i);
       } else if (i <= 0x10ffff) {
         a.add(0xd800 + ((((i - 0x10000) >> 10) & 0x3ff)));
         a.add(0xdc00 + (i & 0x3ff));
       } else {
-        throw new ArgumentError(i);
+        throw _ArgumentError(i);
       }
     }
     return _fromCharCodeApply(a);
   }
 
   static String stringFromCharCodes(charCodes) {
     for (var i in charCodes) {
-      if (i is !int) throw new ArgumentError(i);
-      if (i < 0) throw new ArgumentError(i);
+      if (i is !int) throw _ArgumentError(i);
+      if (i < 0) throw _ArgumentError(i);
       if (i > 0xffff) return stringFromCodePoints(charCodes);
     }
     return _fromCharCodeApply(charCodes);
   }
 
   // [start] and [end] are validated.
   static String stringFromNativeUint8List(
       NativeUint8List charCodes, int start, int end) {
     const kMaxApply = 500;
     if (end <= kMaxApply && start == 0 && end == charCodes.length) {
@@ skipping 168 matching lines @@
 
   static getWeekday(receiver) {
     int weekday = (receiver.isUtc)
       ? JS('int', r'#.getUTCDay() + 0', lazyAsJsDate(receiver))
       : JS('int', r'#.getDay() + 0', lazyAsJsDate(receiver));
     // Adjust by one because JS weeks start on Sunday.
     return (weekday + 6) % 7 + 1;
   }
 
   static valueFromDateString(str) {
-    if (str is !String) throw new ArgumentError(str);
+    if (str is !String) throw _ArgumentError(str);
     var value = JS('num', r'Date.parse(#)', str);
-    if (value.isNaN) throw new ArgumentError(str);
+    if (value.isNaN) throw _ArgumentError(str);
     return value;
   }
 
   static getProperty(object, key) {
     if (object == null || object is bool || object is num || object is String) {
-      throw new ArgumentError(object);
+      throw _ArgumentError(object);
     }
     return JS('var', '#[#]', object, key);
   }
 
   static void setProperty(object, key, value) {
     if (object == null || object is bool || object is num || object is String) {
-      throw new ArgumentError(object);
+      throw _ArgumentError(object);
     }
     JS('void', '#[#] = #', object, key, value);
   }
 
   static functionNoSuchMethod(function,
                               List positionalArguments,
                               Map<String, dynamic> namedArguments) {
     int argumentCount = 0;
     List arguments = [];
     List namedArgumentList = [];
@@ skipping 271 matching lines @@
     JS('void', '#[#] = #', cache, key, value);
   }
 }
 
 /**
  * Called by generated code to throw an illegal-argument exception,
  * for example, if a non-integer index is given to an optimized
  * indexed access.
  */
 iae(argument) {
-  throw new ArgumentError(argument);
+  throw _ArgumentError(argument);
 }
 
 /**
  * Called by generated code to throw an index-out-of-range exception,
  * for example, if a bounds check fails in an optimized indexed
  * access.  This may also be called when the index is not an integer, in
  * which case it throws an illegal-argument exception instead, like
  * [iae], or when the receiver is null.
  */
 ioore(receiver, index) {
   if (receiver == null) receiver.length; // Force a NoSuchMethodError.
   if (index is !int) iae(index);
   throw new RangeError.value(index);
 }
 
 stringLastIndexOfUnchecked(receiver, element, start)
   => JS('int', r'#.lastIndexOf(#, #)', receiver, element, start);
 
 
+/// 'factory' for constructing ArgumentError.value.
+@NoInline()
+ArgumentError _ArgumentError(object) {

[floitsch, 2015/05/13 05:11:29]

it's a function. -> lower case.
 (even if it's to simulate a constructor call).

[sra1, 2015/05/13 22:17:48]

Done.

+  return new ArgumentError.value(object);
+}
+
 checkNull(object) {
-  if (object == null) throw new ArgumentError(null);
+  if (object == null) throw _ArgumentError(object);
   return object;
 }
 
 checkNum(value) {
-  if (value is !num) {
-    throw new ArgumentError(value);
-  }
+  if (value is !num) throw _ArgumentError(value);
   return value;
 }
 
 checkInt(value) {
-  if (value is !int) {
-    throw new ArgumentError(value);
-  }
+  if (value is !int) throw _ArgumentError(value);
   return value;
 }
 
 checkBool(value) {
-  if (value is !bool) {
-    throw new ArgumentError(value);
-  }
+  if (value is !bool) throw _ArgumentError(value);
   return value;
 }
 
 checkString(value) {
-  if (value is !String) {
-    throw new ArgumentError(value);
-  }
+  if (value is !String) throw _ArgumentError(value);
   return value;
 }
 
 /**
  * Wrap the given Dart object and record a stack trace.
  *
  * The code in [unwrapException] deals with getting the original Dart
  * object out of the wrapper again.
  */
 @NoInline()
@@ skipping 2639 matching lines @@
   // This is a function that will return a helper function that does the
   // iteration of the sync*.
   //
   // Each invocation should give a body with fresh state.
   final dynamic /* js function */ _outerHelper;
 
   SyncStarIterable(this._outerHelper);
 
   Iterator get iterator => new SyncStarIterator(JS('', '#()', _outerHelper));
 }