Issue 11366085: Fix control flow graph in the presence of aborting instructions in a try/catch/finally.

Issue 11366085: Fix control flow graph in the presence of aborting instructions in a try/catch/finally. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix control flow graph in the presence of aborting instructions in a try/catch/finally. Committed: https://code.google.com/p/dart/source/detail?r=14554

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+294 lines, -0 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		9 chunks	+39 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1	3 chunks	+14 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/tracer.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	tests/language/try_catch4_test.dart	View		1 chunk	+195 lines, -0 lines	0 comments	Download
A	tests/language/try_catch5_test.dart	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. Please add a try_catch5_test with nested try/catchs. https://codereview.chromium.org/11366085/diff/1006/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right): https://codereview.chromium.org/11366085/diff/1006/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart#newcode1504 sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1504: // ...

8 years, 1 month ago (2012-11-05 14:24:52 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-05 16:58:07 UTC) #3

Thanks Florian.

https://codereview.chromium.org/11366085/diff/1006/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/11366085/diff/1006/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1504: // A [HExitTry]
is used for having the control flow graph of a
On 2012/11/05 14:24:52, floitsch wrote:
> An

Done.

https://codereview.chromium.org/11366085/diff/1006/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1505: // try/catch
block right, ie the try body is always a predecessor
On 2012/11/05 14:24:52, floitsch wrote:
> "right" is a strong word...

Comment updated.

https://codereview.chromium.org/11366085/diff/1006/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right):

https://codereview.chromium.org/11366085/diff/1006/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:2038: // A [HExitTry]
control flow node is used when the body of a try or
On 2012/11/05 14:24:52, floitsch wrote:
> An

Done.

Expand Messages | Collapse Messages