Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 11366078: Report error for deprecated #library #import #source (Closed)

Created:
8 years, 1 month ago by scheglov
Modified:
8 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Report error for deprecated #library #import #source R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -143 lines) Patch
M compiler/java/com/google/dart/compiler/DefaultErrorFormatter.java View 2 chunks +2 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 4 chunks +20 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java View 1 chunk +3 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 2 chunks +15 lines, -6 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java View 1 chunk +0 lines, -20 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java View 3 chunks +8 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/DartElementLocatorTest.java View 10 chunks +25 lines, -25 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameImportProcessor.java View 1 chunk +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameFieldProcessorTest.java View 4 chunks +6 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameImportProcessorTest.java View 25 chunks +54 lines, -54 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameTypeProcessorTest.java View 8 chunks +20 lines, -20 lines 0 comments Download
M pkg/pkg.status View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +149 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +39 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 1 month ago (2012-11-03 02:48:40 UTC) #1
Brian Wilkerson
8 years, 1 month ago (2012-11-05 15:57:10 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698