editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameImportProcessor.java - Issue 11366078: Report error for deprecated #library #import #source

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameImportProcessor.java

Issue 11366078: Report error for deprecated #library #import #source (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/DartElementLocatorTest.java ('k') | editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameFieldProcessorTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameImportProcessor.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameImportProcessor.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameImportProcessor.java

index 22a18a604226c40b7d2a57d3eba77aaded82c167..d19c71614340ee0e3a082cd736b56a7bd2f09de2 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameImportProcessor.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameImportProcessor.java

@@ -119,18 +119,18 @@ public class RenameImportProcessor extends RenameTopLevelProcessor {

CompilationUnit cu = imprt.getCompilationUnit();

String editName = RefactoringCoreMessages.RenameProcessor_update_declaration;

if (hasPrefix && willHavePrefix) {

- SourceRange nameRange = SourceRangeUtils.getExpanded(imprt.getNameRange(), -1);

+ SourceRange nameRange = imprt.getNameRange();

addTextEdit(cu, editName, createTextChange(nameRange));

} else if (!hasPrefix) {

SourceRange uriRange = imprt.getUriRange();

int uriEnd = SourceRangeUtils.getEnd(uriRange);

- addTextEdit(cu, editName, new ReplaceEdit(uriEnd, 0, ", prefix: '" + newName + "'"));

+ addTextEdit(cu, editName, new ReplaceEdit(uriEnd, 0, " as " + newName));

} else if (!willHavePrefix) {

SourceRange uriRange = imprt.getUriRange();

SourceRange sourceRange = imprt.getSourceRange();

int uriEnd = SourceRangeUtils.getEnd(uriRange);

int sourceEnd = SourceRangeUtils.getEnd(sourceRange);

- addTextEdit(cu, editName, new ReplaceEdit(uriEnd, sourceEnd - uriEnd, ");"));

+ addTextEdit(cu, editName, new ReplaceEdit(uriEnd, sourceEnd - uriEnd, ";"));

}