Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1136603002: Remove CompositeResultDescriptor (Closed)

Created:
5 years, 7 months ago by Brian Wilkerson
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -131 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +0 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/src/task/model.dart View 2 chunks +7 lines, -37 lines 2 comments Download
M pkg/analyzer/lib/task/model.dart View 3 chunks +7 lines, -30 lines 0 comments Download
M pkg/analyzer/test/src/task/model_test.dart View 3 chunks +0 lines, -48 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 7 months ago (2015-05-07 19:28:11 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1136603002/diff/1/pkg/analyzer/lib/src/task/model.dart File pkg/analyzer/lib/src/task/model.dart (right): https://codereview.chromium.org/1136603002/diff/1/pkg/analyzer/lib/src/task/model.dart#newcode60 pkg/analyzer/lib/src/task/model.dart:60: ResultDescriptorImpl(this.name, this.defaultValue, Can we make this a constant ...
5 years, 7 months ago (2015-05-07 19:33:50 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1136603002/diff/1/pkg/analyzer/lib/src/task/model.dart File pkg/analyzer/lib/src/task/model.dart (right): https://codereview.chromium.org/1136603002/diff/1/pkg/analyzer/lib/src/task/model.dart#newcode60 pkg/analyzer/lib/src/task/model.dart:60: ResultDescriptorImpl(this.name, this.defaultValue, > Can we make this a constant ...
5 years, 7 months ago (2015-05-07 20:00:30 UTC) #4
Brian Wilkerson
5 years, 7 months ago (2015-05-07 20:01:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45613 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698