Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: pkg/analyzer/lib/task/model.dart

Issue 1136603002: Remove CompositeResultDescriptor (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/task/model.dart
diff --git a/pkg/analyzer/lib/task/model.dart b/pkg/analyzer/lib/task/model.dart
index 0e1b8e65d672dd106b571fcb3004666ce19a8f74..810d6cc47df33bab1ed4eb15a2c86c5a2c05841b 100644
--- a/pkg/analyzer/lib/task/model.dart
+++ b/pkg/analyzer/lib/task/model.dart
@@ -246,28 +246,6 @@ abstract class AnalysisTask {
}
/**
- * A [ResultDescriptor] that denotes an analysis result that is a union of
- * one or more other results.
- *
- * Clients are not expected to subtype this class.
- */
-abstract class CompositeResultDescriptor<V> extends ResultDescriptor<V> {
- /**
- * Initialize a newly created composite result to have the given [name].
- */
- factory CompositeResultDescriptor(
- String name) = CompositeResultDescriptorImpl;
-
- /**
- * Return a list containing the descriptors of the results that are unioned
- * together to compose the value of this result.
- *
- * Clients must not modify the returned list.
- */
- List<ResultDescriptor<V>> get contributors;
-}
-
-/**
* A description of a [List]-based analysis result that can be computed by an
* [AnalysisTask].
*
@@ -275,12 +253,12 @@ abstract class CompositeResultDescriptor<V> extends ResultDescriptor<V> {
*/
abstract class ListResultDescriptor<E> implements ResultDescriptor<List<E>> {
/**
- * Initialize a newly created analysis result to have the given [name]. If a
- * composite result is specified, then this result will contribute to it.
+ * Initialize a newly created analysis result to have the given [name] and
+ * [defaultValue]. If a [cachingPolicy] is provided, it will control how long
+ * values associated with this result will remain in the cache.
*/
factory ListResultDescriptor(String name, List<E> defaultValue,
- {CompositeResultDescriptor<List<E>> contributesTo,
- ResultCachingPolicy<List<E>> cachingPolicy}) = ListResultDescriptorImpl<E>;
+ {ResultCachingPolicy<List<E>> cachingPolicy}) = ListResultDescriptorImpl<E>;
@override
ListTaskInput<E> of(AnalysisTarget target);
@@ -371,16 +349,15 @@ abstract class ResultCachingPolicy<T> {
*/
abstract class ResultDescriptor<V> {
/**
- * Initialize a newly created analysis result to have the given [name]. If a
- * composite result is specified, then this result will contribute to it.
+ * Initialize a newly created analysis result to have the given [name] and
+ * [defaultValue].
*
* The given [cachingPolicy] is used to limit the total size of results
* described by this descriptor. If no policy is specified, the results are
* never evicted from the cache, and removed only when they are invalidated.
*/
factory ResultDescriptor(String name, V defaultValue,
- {CompositeResultDescriptor<V> contributesTo,
- ResultCachingPolicy<V> cachingPolicy}) = ResultDescriptorImpl;
+ {ResultCachingPolicy<V> cachingPolicy}) = ResultDescriptorImpl;
/**
* Return the caching policy for results described by this descriptor.

Powered by Google App Engine
This is Rietveld 408576698