Restrict immediate operands to smi where only smis are supported.

Restrict immediate operands to smi where only smis are supported.

Re-enable redundant phi elimination.

Add x64 codegen templates and assembler instructions for immediate operands.

Fix x64 assembler for imull when using r8-r15.

Add x64 instruction for imulq(reg, imm).

Fix x64 disassembler printing of immediates.
Committed: https://code.google.com/p/dart/source/detail?r=14814

[srdjan, 2012-11-12 20:48:18]

LGTM

https://codereview.chromium.org/11362210/diff/7001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/11362210/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_ia32.cc:899: // Only one input can be a
constant operand.
Why don't you allow both to be constant? You expect that to be handled in the
optimizer instead? (please add comment).

[Florian Schneider, 2012-11-12 22:43:45]

https://codereview.chromium.org/11362210/diff/7001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/11362210/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_ia32.cc:899: // Only one input can be a
constant operand.
On 2012/11/12 20:48:18, srdjan wrote:
> Why don't you allow both to be constant? You expect that to be handled in the
> optimizer instead? (please add comment).

Done.