Change dart_no_snapshot to run native extensions.

Change dart_no_snapshot to run native extensions.


BUG=standalone/test_extension_test

Committed: https://code.google.com/p/dart/source/detail?r=14619

[Bill Hesse, 2012-11-07 10:09:22]

libdart has a separate target libdart_export with these changes, but there seems
no reason to make a separate libdart_withcore_export.  Just changing
libdart_withcore to export the dart API symbols.

[Mads Ager (google), 2012-11-07 10:16:27]

The change to export Dart_True on dart_nosnapshot is the right change. The other
change looks wrong though. Is that really needed?

http://codereview.chromium.org/11362132/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

http://codereview.chromium.org/11362132/diff/1/runtime/bin/bin.gypi#newcode326
runtime/bin/bin.gypi:326: 'DART_SHARED_LIB',
This looks wrong.

'type': 'static_library'

'defines': [ 'DART_SHARED_LIB', ]

???

[Bill Hesse, 2012-11-07 11:23:26]

http://codereview.chromium.org/11362132/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

http://codereview.chromium.org/11362132/diff/1/runtime/bin/bin.gypi#newcode326
runtime/bin/bin.gypi:326: 'DART_SHARED_LIB',
The only effect of DART_SHARED_LIB is to use _declspec(dllexport) (on Windows)
or visibility("default") (on gcc) to make the Dart API visible to libraries that
link with this.  Perhaps it should be renamed to DART_EXPORT_API.  Shall I do
that?


On 2012/11/07 10:16:27, Mads Ager wrote:
> This looks wrong.
> 
> 'type': 'static_library'
> 
> 'defines': [ 'DART_SHARED_LIB', ]
> 
> ???

[Mads Ager (google), 2012-11-07 11:52:00]

lgtm

http://codereview.chromium.org/11362132/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

http://codereview.chromium.org/11362132/diff/1/runtime/bin/bin.gypi#newcode326
runtime/bin/bin.gypi:326: 'DART_SHARED_LIB',
On 2012/11/07 11:23:26, Bill Hesse wrote:
> The only effect of DART_SHARED_LIB is to use _declspec(dllexport) (on Windows)
> or visibility("default") (on gcc) to make the Dart API visible to libraries
that
> link with this.  Perhaps it should be renamed to DART_EXPORT_API.  Shall I do
> that?

OK. This looked weird because of that naming. Add a comment for now?

> On 2012/11/07 10:16:27, Mads Ager wrote:
> > This looks wrong.
> > 
> > 'type': 'static_library'
> > 
> > 'defines': [ 'DART_SHARED_LIB', ]
> > 
> > ???
>

[Ivan Posva, 2012-11-08 20:32:12]

DBC -ip

http://codereview.chromium.org/11362132/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

http://codereview.chromium.org/11362132/diff/1/runtime/bin/bin.gypi#newcode326
runtime/bin/bin.gypi:326: 'DART_SHARED_LIB',
On 2012/11/07 11:52:00, Mads Ager wrote:
> On 2012/11/07 11:23:26, Bill Hesse wrote:
> > The only effect of DART_SHARED_LIB is to use _declspec(dllexport) (on
Windows)
> > or visibility("default") (on gcc) to make the Dart API visible to libraries
> that
> > link with this.  Perhaps it should be renamed to DART_EXPORT_API.  Shall I
do
> > that?

Siva and I discussed earlier today whether we should just change the default to
always export. And yes, we would change the name of the flag at that point as
well. Just having a comment for now is fine.

> 
> OK. This looked weird because of that naming. Add a comment for now?
> 
> > On 2012/11/07 10:16:27, Mads Ager wrote:
> > > This looks wrong.
> > > 
> > > 'type': 'static_library'
> > > 
> > > 'defines': [ 'DART_SHARED_LIB', ]
> > > 
> > > ???
> > 
>

http://codereview.chromium.org/11362132/diff/1/runtime/bin/bin.gypi#newcode479
runtime/bin/bin.gypi:479: # Extensions use this import library to link to the
API in dart.exe.
This is actually dart_no_snapshot.exe. Can you also add a clarification comment
that states whether all Dart_* are exported or is it only Dart_True? If only
Dart_True, why is that enough?