Change dart_no_snapshot to run native extensions.

runtime/bin/bin.gypi

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 {
   'variables': {
     'crypto_cc_file': '<(SHARED_INTERMEDIATE_DIR)/crypto_gen.cc',
     'io_cc_file': '<(SHARED_INTERMEDIATE_DIR)/io_gen.cc',
     'io_patch_cc_file': '<(SHARED_INTERMEDIATE_DIR)/io_patch_gen.cc',
     'json_cc_file': '<(SHARED_INTERMEDIATE_DIR)/json_gen.cc',
@@ skipping 304 matching lines @@
       'include_dirs': [
         '..',
       ],
       'sources': [
         '../include/dart_api.h',
         '../include/dart_debugger_api.h',
         '../vm/dart_api_impl.cc',
         '../vm/debugger_api_impl.cc',
         '<(version_cc_file)',
       ],
+      'defines': [
+        'DART_SHARED_LIB',

[Mads Ager (google), 2012/11/07 10:16:27]

This looks wrong.

'type': 'static_library'

'defines': [ 'DART_SHARED_LIB', ]

???

[Bill Hesse, 2012/11/07 11:23:26]

The only effect of DART_SHARED_LIB is to use _declspec(dllexport) (on Windows)
or visibility("default") (on gcc) to make the Dart API visible to libraries that
link with this.  Perhaps it should be renamed to DART_EXPORT_API.  Shall I do
that?


On 2012/11/07 10:16:27, Mads Ager wrote:

[Mads Ager (google), 2012/11/07 11:52:00]

OK. This looked weird because of that naming. Add a comment for now?

[Ivan Posva, 2012/11/08 20:32:12]

Siva and I discussed earlier today whether we should just change the default to
always export. And yes, we would change the name of the flag at that point as
well. Just having a comment for now is fine.

+      ],
     },
     {
       # Completely statically linked binary for generating snapshots.
       'target_name': 'gen_snapshot',
       'type': 'executable',
       'dependencies': [
         'libdart_withcore',
         'libdart_builtin',
       ],
       'include_dirs': [
@@ skipping 130 matching lines @@
         '<(json_cc_file)',
         '<(uri_cc_file)',
         '<(utf_cc_file)',
         'snapshot_empty.cc',
       ],
       'conditions': [
         ['OS=="win"', {
           'link_settings': {
             'libraries': [ '-lws2_32.lib', '-lRpcrt4.lib' ],
           },
+          # Generate an import library on Windows, by exporting a function.
+          # Extensions use this import library to link to the API in dart.exe.

[Ivan Posva, 2012/11/08 20:32:12]

This is actually dart_no_snapshot.exe. Can you also add a clarification comment
that states whether all Dart_* are exported or is it only Dart_True? If only
Dart_True, why is that enough?

+          'msvs_settings': {
+            'VCLinkerTool': {
+              'AdditionalOptions': [ '/EXPORT:Dart_True' ],
+            },
+          },
        }]],
     },
     {
       'target_name': 'process_test',
       'type': 'executable',
       'sources': [
         'process_test.cc',
       ]
     },
     {
@@ skipping 72 matching lines @@
         ['OS=="mac"', {
           'xcode_settings': {
             'OTHER_LDFLAGS': [ '-undefined', 'dynamic_lookup' ],
           },
         }],
       ],
     },
   ],
 }