Issue 1136163002: Some more cleanup of the finger print checking code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1136163002: Some more cleanup of the finger print checking code. (Closed)

Created:
5 years, 7 months ago by siva

Modified:
5 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -20 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1	2 chunks	+1 line, -20 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+35 lines, -0 lines	0 comments	Download
M	runtime/vm/method_recognizer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/symbols.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

siva

5 years, 7 months ago (2015-05-12 18:14:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r45742 (presubmit successful).