Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Unified Diff: runtime/vm/flow_graph_builder.h

Issue 1136163002: Some more cleanup of the finger print checking code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.h
===================================================================
--- runtime/vm/flow_graph_builder.h (revision 45703)
+++ runtime/vm/flow_graph_builder.h (working copy)
@@ -30,7 +30,6 @@
// List of recognized list factories:
// (factory-name-symbol, result-cid, fingerprint).
-// TODO(srdjan): Store the values in the snapshot instead.
#define RECOGNIZED_LIST_FACTORY_LIST(V) \
V(_ListFactory, kArrayCid, 335347617) \
V(_GrowableListWithData, kGrowableObjectArrayCid, 536409567) \
@@ -53,25 +52,7 @@
class FactoryRecognizer : public AllStatic {
public:
// Return kDynamicCid if factory is not recognized.
- static intptr_t ResultCid(const Function& factory) {
- ASSERT(factory.IsFactory());
- const Class& function_class = Class::Handle(factory.Owner());
- const Library& lib = Library::Handle(function_class.library());
- ASSERT((lib.raw() == Library::CoreLibrary()) ||
- (lib.raw() == Library::TypedDataLibrary()));
- const String& factory_name = String::Handle(factory.name());
-#define RECOGNIZE_FACTORY(test_factory_symbol, cid, fp) \
- if (String::EqualsIgnoringPrivateKey( \
- factory_name, Symbols::test_factory_symbol())) { \
- CHECK_FINGERPRINT2(factory, test_factory_symbol, cid, fp); \
- return cid; \
- } \
-
-RECOGNIZED_LIST_FACTORY_LIST(RECOGNIZE_FACTORY);
-#undef RECOGNIZE_FACTORY
-
- return kDynamicCid;
- }
+ static intptr_t ResultCid(const Function& factory);
};
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698