Issue 11361036: Revert instance inlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11361036: Revert instance inlining. (Closed)

Created:
8 years, 1 month ago by Johnni Winther

Modified:
8 years, 1 month ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert instance inlining. Committed: https://code.google.com/p/dart/source/detail?r=14455

Patch Set 2 : Update cf. comments #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -0 lines)			Patch
M	lib/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/instance_inline_test.dart	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
A	tests/language/static_inline_test.dart	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

Instance inlining made the added test utils/instance_inline_test failed since the argument to charAt was evaluated ...

8 years, 1 month ago (2012-11-01 15:19:54 UTC) #1

kasperl

LGTM, but I guess you need to update the status files. https://codereview.chromium.org/11361036/diff/1/lib/compiler/implementation/ssa/builder.dart File lib/compiler/implementation/ssa/builder.dart (left): ...

8 years, 1 month ago (2012-11-01 15:36:11 UTC) #3

ngeoffray

8 years, 1 month ago (2012-11-01 15:37:37 UTC) #4

https://codereview.chromium.org/11361036/diff/1/tests/utils/instance_inline_t...
File tests/utils/instance_inline_test.dart (right):

https://codereview.chromium.org/11361036/diff/1/tests/utils/instance_inline_t...
tests/utils/instance_inline_test.dart:1: // Copyright (c) 2012, the Dart project
authors.  Please see the AUTHORS file
I think we put these tests usually in tests/language.

Expand Messages | Collapse Messages

Issue 11361036: Revert instance inlining. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Update cf. comments #

Messages