Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: lib/compiler/implementation/ssa/builder.dart

Issue 11361036: Revert instance inlining. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of ssa; 5 part of ssa;
6 6
7 class Interceptors { 7 class Interceptors {
8 Compiler compiler; 8 Compiler compiler;
9 Interceptors(Compiler this.compiler); 9 Interceptors(Compiler this.compiler);
10 10
(...skipping 2549 matching lines...) Expand 10 before | Expand all | Expand 10 after
2560 2560
2561 if (node.receiver == null) { 2561 if (node.receiver == null) {
2562 inputs.add(localsHandler.readThis()); 2562 inputs.add(localsHandler.readThis());
2563 } else { 2563 } else {
2564 visit(node.receiver); 2564 visit(node.receiver);
2565 inputs.add(pop()); 2565 inputs.add(pop());
2566 } 2566 }
2567 2567
2568 addDynamicSendArgumentsToList(node, inputs); 2568 addDynamicSendArgumentsToList(node, inputs);
2569 2569
2570 Element element = elements[node];
2571 if (element != null && compiler.world.hasNoOverridingMember(element)) {
2572 if (tryInlineMethod(element, selector, node.arguments)) {
kasperl 2012/11/01 15:36:11 Maybe just disable it here with a 'false && ' cond
2573 return;
2574 }
2575 }
2576 // The first entry in the inputs list is the receiver. 2570 // The first entry in the inputs list is the receiver.
2577 pushWithPosition(new HInvokeDynamicMethod(selector, inputs), node); 2571 pushWithPosition(new HInvokeDynamicMethod(selector, inputs), node);
2578 2572
2579 if (isNotEquals) { 2573 if (isNotEquals) {
2580 HNot not = new HNot(popBoolified()); 2574 HNot not = new HNot(popBoolified());
2581 push(not); 2575 push(not);
2582 } 2576 }
2583 } 2577 }
2584 2578
2585 visitClosureSend(Send node) { 2579 visitClosureSend(Send node) {
(...skipping 2023 matching lines...) Expand 10 before | Expand all | Expand 10 after
4609 new HSubGraphBlockInformation(elseBranch.graph)); 4603 new HSubGraphBlockInformation(elseBranch.graph));
4610 4604
4611 HBasicBlock conditionStartBlock = conditionBranch.block; 4605 HBasicBlock conditionStartBlock = conditionBranch.block;
4612 conditionStartBlock.setBlockFlow(info, joinBlock); 4606 conditionStartBlock.setBlockFlow(info, joinBlock);
4613 SubGraph conditionGraph = conditionBranch.graph; 4607 SubGraph conditionGraph = conditionBranch.graph;
4614 HIf branch = conditionGraph.end.last; 4608 HIf branch = conditionGraph.end.last;
4615 assert(branch is HIf); 4609 assert(branch is HIf);
4616 branch.blockInformation = conditionStartBlock.blockFlow; 4610 branch.blockInformation = conditionStartBlock.blockFlow;
4617 } 4611 }
4618 } 4612 }
OLDNEW
« no previous file with comments | « no previous file | tests/utils/instance_inline_test.dart » ('j') | tests/utils/instance_inline_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698