Issue 11358249: Fixing SVGElement.classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11358249: Fixing SVGElement.classes. (Closed)

Created:
8 years, 1 month ago by blois

Modified:
8 years, 1 month ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing SVGElement.classes. BUG=5008 Committed: https://code.google.com/p/dart/source/detail?r=14929

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -6 lines)			Patch
M	sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate	View	3 chunks	+7 lines, -2 lines	2 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	3 chunks	+7 lines, -2 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	3 chunks	+7 lines, -2 lines	0 comments	Download
M	tests/html/svgelement_test.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm https://codereview.chromium.org/11358249/diff/1/sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate File sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate (left): https://codereview.chromium.org/11358249/diff/1/sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate#oldcode26 sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate:26: _element.attributes['class'] = _formatSet(s); wow, did this just not ...

8 years, 1 month ago (2012-11-14 23:33:24 UTC) #2

blois

8 years, 1 month ago (2012-11-14 23:37:19 UTC) #3

https://codereview.chromium.org/11358249/diff/1/sdk/lib/html/templates/html/i...
File sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate (left):

https://codereview.chromium.org/11358249/diff/1/sdk/lib/html/templates/html/i...
sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate:26:
_element.attributes['class'] = _formatSet(s);
On 2012/11/14 23:33:24, Emily Fortuna wrote:
> wow, did this just not work before? I can't find _formatSet defined anywhere
in
> the lib directory

I would have broken this with some refactoring that I did for SVG, but it looks
like it was already broken because _cssClassSet was not defined.

It was completely broken.

Expand Messages | Collapse Messages