Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: sdk/lib/svg/dartium/svg_dartium.dart

Issue 11358249: Fixing SVGElement.classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/svg/dartium/svg_dartium.dart
diff --git a/sdk/lib/svg/dartium/svg_dartium.dart b/sdk/lib/svg/dartium/svg_dartium.dart
index e1f321d1888e0c103d5254a45d7c61d1d053ac05..f372945c46b34f13b4cdff6e6f9b6fd1ae5b8bf9 100644
--- a/sdk/lib/svg/dartium/svg_dartium.dart
+++ b/sdk/lib/svg/dartium/svg_dartium.dart
@@ -1370,6 +1370,9 @@ class _AttributeClassSet extends CssClassSet {
var classname = _element.attributes['class'];
Set<String> s = new Set<String>();
+ if (classname == null) {
+ return s;
+ }
for (String name in classname.split(' ')) {
String trimmed = name.trim();
if (!trimmed.isEmpty) {
@@ -1380,7 +1383,8 @@ class _AttributeClassSet extends CssClassSet {
}
void writeClasses(Set s) {
- _element.attributes['class'] = _formatSet(s);
+ List list = new List.from(s);
+ _element.attributes['class'] = Strings.join(list, ' ');
}
}
@@ -1390,9 +1394,10 @@ class SVGElement extends Element {
factory SVGElement.svg(String svg) =>
_SVGElementFactoryProvider.createSVGElement_svg(svg);
+ _AttributeClassSet _cssClassSet;
CssClassSet get classes {
if (_cssClassSet == null) {
- _cssClassSet = new _AttributeClassSet(_ptr);
+ _cssClassSet = new _AttributeClassSet(this);
}
return _cssClassSet;
}

Powered by Google App Engine
This is Rietveld 408576698