Issue 11358052: Various little cleanups to avoid excessive allocation of handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11358052: Various little cleanups to avoid excessive allocation of handles. (Closed)

Created:
8 years, 1 month ago by srdjan

Modified:
8 years, 1 month ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Various little cleanups to avoid excessive allocation of handles. Committed: https://code.google.com/p/dart/source/detail?r=14486

Patch Set 3 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -26 lines)			Patch
M	runtime/vm/flow_graph_compiler.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	5 chunks	+10 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	6 chunks	+17 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM with one comment. https://codereview.chromium.org/11358052/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/11358052/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode1179 runtime/vm/flow_graph_optimizer.cc:1179: instr->set_ic_data(&unary_checks); The comment says 'too ...

8 years, 1 month ago (2012-11-02 01:09:18 UTC) #2

srdjan

8 years, 1 month ago (2012-11-02 15:32:45 UTC) #3

https://codereview.chromium.org/11358052/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11358052/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1179: instr->set_ic_data(&unary_checks);
On 2012/11/02 01:09:18, siva wrote:
> The comment says 'too many checks, leave it megamorphic' but
> looks like you are changing stuff here.

Changed the comment:
    // Too many checks it will be megamorphic which needs unary checks.

Expand Messages | Collapse Messages

Issue 11358052: Various little cleanups to avoid excessive allocation of handles. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages