runtime/vm/flow_graph_compiler.cc - Issue 11358052: Various little cleanups to avoid excessive allocation of handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 11358052: Various little cleanups to avoid excessive allocation of handles. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler.cc

===================================================================

--- runtime/vm/flow_graph_compiler.cc (revision 14483)

+++ runtime/vm/flow_graph_compiler.cc (working copy)

@@ -576,8 +576,9 @@

LocationSummary* locs) {

ASSERT(!ic_data.IsNull() && (ic_data.NumberOfChecks() > 0));

Label match_found;

- for (intptr_t i = 0; i < ic_data.NumberOfChecks(); i++) {

- const bool is_last_check = (i == (ic_data.NumberOfChecks() - 1));

+ const intptr_t len = ic_data.NumberOfChecks();

+ for (intptr_t i = 0; i < len; i++) {

+ const bool is_last_check = (i == (len - 1));

Label next_test;

assembler()->cmpl(class_id_reg, Immediate(ic_data.GetReceiverClassIdAt(i)));

if (is_last_check) {

« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »