ParameterMirror extends VariableMirror

ParameterMirror extends VariableMirror

Committed: https://code.google.com/p/dart/source/detail?r=14322

[kasperl, 2012-10-31 09:52:08]

LGTM. Do you have any tests of the isNamed functionality?

http://codereview.chromium.org/11358005/diff/1/pkg/dartdoc/lib/src/mirrors/da...
File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right):

http://codereview.chromium.org/11358005/diff/1/pkg/dartdoc/lib/src/mirrors/da...
pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:51: system, method, link.head,
true, signature.optionalParametersAreNamed));
Maybe cache this outside the loop? It looks like it's a per parameter thing but
it's really only dependent on the signature. 

   bool isNamed = signature.optionalParametersAreNamed;

[Johnni Winther, 2012-10-31 10:11:44]

http://codereview.chromium.org/11358005/diff/1/pkg/dartdoc/lib/src/mirrors/da...
File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right):

http://codereview.chromium.org/11358005/diff/1/pkg/dartdoc/lib/src/mirrors/da...
pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:51: system, method, link.head,
true, signature.optionalParametersAreNamed));
On 2012/10/31 09:52:08, kasperl wrote:
> Maybe cache this outside the loop? It looks like it's a per parameter thing
but
> it's really only dependent on the signature. 
> 
>    bool isNamed = signature.optionalParametersAreNamed;

Done.

[ahe, 2012-11-06 15:49:20]

lgtm