ParameterMirror extends VariableMirror

pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library mirrors_dart2js;
 
 import 'dart:io';
 import 'dart:uri';
 
 import '../../../../../lib/compiler/compiler.dart' as diagnostics;
@@ skipping 24 matching lines @@
 }
 
 List<ParameterMirror> _parametersFromFunctionSignature(
     Dart2JsMirrorSystem system,
     Dart2JsMethodMirror method,
     FunctionSignature signature) {
   var parameters = <ParameterMirror>[];
   Link<Element> link = signature.requiredParameters;
   while (!link.isEmpty) {
     parameters.add(new Dart2JsParameterMirror(
-        system, method, link.head, false));
+        system, method, link.head, false, false));
     link = link.tail;
   }
   link = signature.optionalParameters;
   while (!link.isEmpty) {
     parameters.add(new Dart2JsParameterMirror(
-        system, method, link.head, true));
+        system, method, link.head, true, signature.optionalParametersAreNamed));

[kasperl, 2012/10/31 09:52:08]

Maybe cache this outside the loop? It looks like it's a per parameter thing but
it's really only dependent on the signature. 

   bool isNamed = signature.optionalParametersAreNamed;

[Johnni Winther, 2012/10/31 10:11:44]

Done.

     link = link.tail;
   }
   return parameters;
 }
 
 Dart2JsTypeMirror _convertTypeToTypeMirror(
     Dart2JsMirrorSystem system,
     DartType type,
     InterfaceType defaultType,
     [FunctionSignature functionSignature]) {
@@ skipping 323 matching lines @@
 }
 
 abstract class Dart2JsDeclarationMirror
     implements Dart2JsMirror, DeclarationMirror {
 
   bool get isTopLevel => owner != null && owner is LibraryMirror;
 
   bool get isPrivate => _isPrivate(simpleName);
 }
 
-abstract class Dart2JsMemberMirror extends Dart2JsDeclarationMirror
+abstract class Dart2JsMemberMirror extends Dart2JsElementMirror
     implements MemberMirror {
 
+  Dart2JsMemberMirror(Dart2JsMirrorSystem system, Element element)
+      : super(system, element);
+
+  bool get isConstructor => false;
+
+  bool get isField => false;
+
+  bool get isMethod => false;
+
+  bool get isStatic => false;
 }
 
 abstract class Dart2JsTypeMirror extends Dart2JsDeclarationMirror
     implements TypeMirror {
 
 }
 
 abstract class Dart2JsElementMirror extends Dart2JsDeclarationMirror {
   final Dart2JsMirrorSystem system;
   final Element _element;
@@ skipping 224 matching lines @@
 class Dart2JsSource implements Source {
   Script _script;
 
   Dart2JsSource(this._script);
 
   Uri get uri => _script.uri;
 
   String get text => _script.text;
 }
 
-class Dart2JsParameterMirror extends Dart2JsElementMirror
+class Dart2JsParameterMirror extends Dart2JsMemberMirror
     implements ParameterMirror {
   final MethodMirror _method;
   final bool isOptional;
+  final bool isNamed;
 
   factory Dart2JsParameterMirror(Dart2JsMirrorSystem system,
                                  MethodMirror method,
                                  VariableElement element,
-                                 bool isOptional) {
+                                 bool isOptional,
+                                 bool isNamed) {
     if (element is FieldParameterElement) {
       return new Dart2JsFieldParameterMirror(system,
-                                             method, element, isOptional);
+          method, element, isOptional, isNamed);
     }
     return new Dart2JsParameterMirror._normal(system,
-                                              method, element, isOptional);
+        method, element, isOptional, isNamed);
   }
 
   Dart2JsParameterMirror._normal(Dart2JsMirrorSystem system,
                          this._method,
                          VariableElement element,
-                         this.isOptional)
+                         this.isOptional,
+                         this.isNamed)
     : super(system, element);
 
   DeclarationMirror get owner => _method;
 
   VariableElement get _variableElement => _element;
 
   String get qualifiedName => '${_method.qualifiedName}#${simpleName}';
 
   TypeMirror get type => _convertTypeToTypeMirror(system,
       _variableElement.computeType(system.compiler),
       system.compiler.types.dynamicType,
       _variableElement.variables.functionSignature);
 
+
+  bool get isFinal => false;
+
+  bool get isConst => false;
+
   String get defaultValue {
     if (hasDefaultValue) {
       SendSet expression = _variableElement.cachedNode.asSendSet();
       return unparse(expression.arguments.head);
     }
     return null;
   }
+
   bool get hasDefaultValue {
     return _variableElement.cachedNode !== null &&
         _variableElement.cachedNode is SendSet;
   }
 
   bool get isInitializingFormal => false;
 
   VariableMirror get initializedField => null;
 }
 
 class Dart2JsFieldParameterMirror extends Dart2JsParameterMirror {
 
   Dart2JsFieldParameterMirror(Dart2JsMirrorSystem system,
                               MethodMirror method,
                               FieldParameterElement element,
-                              bool isOptional)
-      : super._normal(system, method, element, isOptional);
+                              bool isOptional,
+                              bool isNamed)
+      : super._normal(system, method, element, isOptional, isNamed);
 
   FieldParameterElement get _fieldParameterElement => _element;
 
   TypeMirror get type {
     if (_fieldParameterElement.variables.cachedNode.type !== null) {
       return super.type;
     }
     return _convertTypeToTypeMirror(system,
       _fieldParameterElement.fieldElement.computeType(system.compiler),
       system.compiler.types.dynamicType,
@@ skipping 573 matching lines @@
       return false;
     }
     return other.isDynamic;
   }
 }
 
 //------------------------------------------------------------------------------
 // Member mirrors implementation.
 //------------------------------------------------------------------------------
 
-class Dart2JsMethodMirror extends Dart2JsElementMirror
-    implements Dart2JsMemberMirror, MethodMirror {
+class Dart2JsMethodMirror extends Dart2JsMemberMirror
+    implements MethodMirror {
   final Dart2JsObjectMirror _objectMirror;
   String _simpleName;
   String _displayName;
   String _constructorName;
   String _operatorName;
   Dart2JsMethodKind _kind;
 
   Dart2JsMethodMirror(Dart2JsObjectMirror objectMirror,
                       FunctionElement function)
       : this._objectMirror = objectMirror,
@@ skipping 65 matching lines @@
   String get qualifiedName
       => '${owner.qualifiedName}.$simpleName';
 
   DeclarationMirror get owner => _objectMirror;
 
   bool get isTopLevel => _objectMirror is LibraryMirror;
 
   bool get isConstructor
       => _kind == Dart2JsMethodKind.CONSTRUCTOR || isConst || isFactory;
 
-  bool get isField => false;
-
   bool get isMethod => !isConstructor;
 
   bool get isPrivate =>
       isConstructor ? _isPrivate(constructorName) : _isPrivate(simpleName);
 
   bool get isStatic => _function.modifiers.isStatic();
 
   List<ParameterMirror> get parameters {
     return _parametersFromFunctionSignature(system, this,
         _function.computeSignature(system.compiler));
@@ skipping 24 matching lines @@
     if (node !== null) {
       var script = _function.getCompilationUnit().script;
       var span = system.compiler.spanFromNode(node, script.uri);
       return new Dart2JsLocation(script, span);
     }
     return super.location;
   }
 
 }
 
-class Dart2JsFieldMirror extends Dart2JsElementMirror
-    implements Dart2JsMemberMirror, VariableMirror {
+class Dart2JsFieldMirror extends Dart2JsMemberMirror implements VariableMirror {
   Dart2JsObjectMirror _objectMirror;
   VariableElement _variable;
 
   Dart2JsFieldMirror(Dart2JsObjectMirror objectMirror,
                      VariableElement variable)
       : this._objectMirror = objectMirror,
         this._variable = variable,
         super(objectMirror.system, variable);
 
   String get qualifiedName
       => '${owner.qualifiedName}.$simpleName';
 
   DeclarationMirror get owner => _objectMirror;
 
   bool get isTopLevel => _objectMirror is LibraryMirror;
 
-  bool get isConstructor => false;
-
   bool get isField => true;
 
-  bool get isMethod => false;
-
   bool get isStatic => _variable.modifiers.isStatic();
 
   bool get isFinal => _variable.modifiers.isFinal();
 
   bool get isConst => _variable.modifiers.isConst();
 
   TypeMirror get type => _convertTypeToTypeMirror(system,
       _variable.computeType(system.compiler),
       system.compiler.types.dynamicType);
 
   SourceLocation get location {
     var script = _variable.getCompilationUnit().script;
     var node = _variable.variables.parseNode(_diagnosticListener);
     if (node !== null) {
       var span = system.compiler.spanFromNode(node, script.uri);
       return new Dart2JsLocation(script, span);
     } else {
       var span = system.compiler.spanFromElement(_variable);
       return new Dart2JsLocation(script, span);
     }
   }
 }