Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1135353002: dart2js: remove bad assumptions in js_helper library. (Closed)

Created:
5 years, 7 months ago by floitsch
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: remove bad assumptions in js_helper library. Cleans up some code. Committed: https://code.google.com/p/dart/source/detail?r=45757

Patch Set 1 #

Patch Set 2 : Undo one change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
floitsch
5 years, 7 months ago (2015-05-13 01:49:55 UTC) #2
floitsch
Needed to revert one of the changes.
5 years, 7 months ago (2015-05-13 05:04:35 UTC) #3
karlklose
LGMT.
5 years, 7 months ago (2015-05-13 06:33:10 UTC) #4
floitsch
Committed patchset #2 (id:20001) manually as 45757 (presubmit successful).
5 years, 7 months ago (2015-05-13 06:35:52 UTC) #5
lilianareyes171755
5 years, 7 months ago (2015-05-18 08:34:31 UTC) #7
Message was sent while issue was closed. 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698