Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_helper.dart

Issue 1135353002: dart2js: remove bad assumptions in js_helper library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Undo one change Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/js_lib/js_helper.dart
diff --git a/sdk/lib/_internal/compiler/js_lib/js_helper.dart b/sdk/lib/_internal/compiler/js_lib/js_helper.dart
index f0d7ebf803f1ff4c4edb2752038a87e466b39232..6965d8af7e41f2b58d1074e758de0cae1a2f2ea0 100644
--- a/sdk/lib/_internal/compiler/js_lib/js_helper.dart
+++ b/sdk/lib/_internal/compiler/js_lib/js_helper.dart
@@ -3313,7 +3313,7 @@ RuntimeFunctionType buildNamedFunctionType(returnType,
}
RuntimeType buildInterfaceType(rti, typeArguments) {
- String name = JS('String|Null', r'#.name', rti);
+ String name = JS('String', r'#.name', rti);
if (typeArguments == null || typeArguments.isEmpty) {
return new RuntimeTypePlain(name);
}
@@ -3370,7 +3370,7 @@ RuntimeType convertRtiToRuntimeType(rti) {
if (rti == null) {
return getDynamicRuntimeType();
} else if (JS('bool', 'typeof # == "function"', rti)) {
- return new RuntimeTypePlain(JS('String', r'rti.name'));
+ return new RuntimeTypePlain(JS('String', r'#.name', rti));
} else if (JS('bool', '#.constructor == Array', rti)) {
List list = JS('JSFixedArray', '#', rti);
String name = JS('String', r'#.name', list[0]);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698