Handle vmservice messages while at breakpoint.

Handle vmservice messages while at breakpoint.

Allow rudimentary inspection of breakpoints from vmservice.

R=hausner@google.com, johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31233

[turnidge, 2013-12-17 20:32:29]

John - please review all
Matthias - please review dbg_* and debugger*.

thanks,

Todd

[hausner, 2013-12-17 21:04:33]

debugger* LGTM with comments.

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/debugger.h
File runtime/vm/debugger.h (right):

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/debugger.h#ne...
runtime/vm/debugger.h:47: void PrintToJSONStream(JSONStream* stream) const;
Should you import the header that defines JSONStream, or do a forward
declaration. Apparently we are including it indirectly somehow, but I think it's
cleaner if the header is self-contained.

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/debugger.h#ne...
runtime/vm/debugger.h:360: void PrintBreakpointsToJSONArray(JSONArray* jsarr)
const;
ditto

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/debugger_api_...
File runtime/vm/debugger_api_impl.cc (right):

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/debugger_api_...
runtime/vm/debugger_api_impl.cc:978: return isolate->debugger()->GetIsolateId();
Not for this change, but maybe it's time to move the id accessor from the
debugger to the isolate.

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/json_stream.h
File runtime/vm/json_stream.h (right):

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/json_stream.h...
runtime/vm/json_stream.h:18: class SourceBreakpoint;
Ouch. The debugger starts creeping into other parts of the system...

[turnidge, 2013-12-17 21:50:00]

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/debugger.h
File runtime/vm/debugger.h (right):

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/debugger.h#ne...
runtime/vm/debugger.h:47: void PrintToJSONStream(JSONStream* stream) const;
On 2013/12/17 21:04:33, hausner wrote:
> Should you import the header that defines JSONStream, or do a forward
> declaration. Apparently we are including it indirectly somehow, but I think
it's
> cleaner if the header is self-contained.

Header is now included in the .cc file.  I have put forward class declarations
in this file.

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/debugger.h#ne...
runtime/vm/debugger.h:360: void PrintBreakpointsToJSONArray(JSONArray* jsarr)
const;
On 2013/12/17 21:04:33, hausner wrote:
> ditto

Done.

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/debugger_api_...
File runtime/vm/debugger_api_impl.cc (right):

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/debugger_api_...
runtime/vm/debugger_api_impl.cc:978: return isolate->debugger()->GetIsolateId();
On 2013/12/17 21:04:33, hausner wrote:
> Not for this change, but maybe it's time to move the id accessor from the
> debugger to the isolate. 

Interestingly, it is already there, isolate->debugger()->GetIsolate() ==
isolate->main_port().

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/json_stream.h
File runtime/vm/json_stream.h (right):

https://codereview.chromium.org/113513004/diff/40001/runtime/vm/json_stream.h...
runtime/vm/json_stream.h:18: class SourceBreakpoint;
On 2013/12/17 21:04:33, hausner wrote:
> Ouch. The debugger starts creeping into other parts of the system... 

The design of JSONStream is such that it needs a specific override to be able to
print special objects, so it's kind of hard to avoid creeping into this file.

If Breakpoint ever became a first-class Object in the heap, then it would be
covered by the Object cases.

[turnidge, 2013-12-17 21:50:57]

Some changes in service_test.cc.  Ivan forced me to become more clever in the
unit test around creating a mock port :-).

[Cutch, 2013-12-18 05:34:17]

lgtm

[turnidge, 2013-12-18 17:45:30]

Committed patchset #8 manually as r31233 (presubmit successful).