Handle vmservice messages while at breakpoint.

runtime/vm/debugger.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_DEBUGGER_H_
 #define VM_DEBUGGER_H_
 
 #include "include/dart_debugger_api.h"
 
 #include "vm/object.h"
@@ skipping 18 matching lines @@
 
   RawFunction* function() const { return function_; }
   intptr_t token_pos() const { return token_pos_; }
   void set_token_pos(intptr_t value) { token_pos_ = value; }
   intptr_t id() const { return id_; }
 
   RawScript* SourceCode();
   RawString* SourceUrl();
   intptr_t LineNumber();
 
-  void GetCodeLocation(Library* lib, Script* script, intptr_t* token_pos);
+  void GetCodeLocation(Library* lib,
+                       Script* script,
+                       intptr_t* token_pos) const;
 
   void Enable();
   void Disable();
   bool IsEnabled() const { return is_enabled_; }
 
+  void PrintToJSONStream(JSONStream* stream) const;

[hausner, 2013/12/17 21:04:33]

Should you import the header that defines JSONStream, or do a forward
declaration. Apparently we are including it indirectly somehow, but I think it's
cleaner if the header is self-contained.

[turnidge, 2013/12/17 21:50:01]

Header is now included in the .cc file.  I have put forward class declarations
in this file.

+
  private:
   void VisitObjectPointers(ObjectPointerVisitor* visitor);
 
   void set_function(const Function& func);
   void set_next(SourceBreakpoint* value) { next_ = value; }
   SourceBreakpoint* next() const { return this->next_; }
 
   const intptr_t id_;
   RawFunction* function_;
   intptr_t token_pos_;
@@ skipping 291 matching lines @@
                             const String& field_name);
 
   void SignalBpReached();
   void SingleStepCallback();
 
   void SignalExceptionThrown(const Instance& exc);
   static void SignalIsolateEvent(EventType type);
 
   uword GetPatchedStubAddress(uword breakpoint_address);
 
+  void PrintBreakpointsToJSONArray(JSONArray* jsarr) const;

[hausner, 2013/12/17 21:04:33]

ditto

[turnidge, 2013/12/17 21:50:01]

Done.

+
   static bool IsDebuggable(const Function& func);
 
  private:
   enum ResumeAction {
     kContinue,
     kStepOver,
     kStepOut,
     kSingleStep
   };
 
@@ skipping 80 matching lines @@
 
   friend class Isolate;
   friend class SourceBreakpoint;
   DISALLOW_COPY_AND_ASSIGN(Debugger);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_DEBUGGER_H_