Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 11348313: Revert "Creating a common library for all DOM types." (Closed)

Created:
8 years ago by blois
Modified:
8 years ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Creating a common library for all DOM types." This reverts commit 11316113. This broke snapshotting on Dartium (which I'm quite sure that I tested). BUG= Committed: https://code.google.com/p/dart/source/detail?r=15566

Patch Set 1 #

Patch Set 2 : Oddities with upload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1535 lines, -1233 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +1 line, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 73 chunks +716 lines, -351 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 39 chunks +365 lines, -306 lines 0 comments Download
M sdk/lib/html/docs/svg_docs.json View 2 chunks +2 lines, -2 lines 0 comments Download
D sdk/lib/html/html_common/collections.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D sdk/lib/html/html_common/conversions.dart View 1 chunk +0 lines, -337 lines 0 comments Download
D sdk/lib/html/html_common/html_common_dart2js.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D sdk/lib/html/html_common/html_common_dartium.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M sdk/lib/html/scripts/generator.py View 7 chunks +17 lines, -16 lines 0 comments Download
A + sdk/lib/html/src/_Collections.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/html/src/dart2js_Conversions.dart View 3 chunks +306 lines, -2 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/html_dart2js.darttemplate View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/html/templates/html/dartium/html_dartium.darttemplate View 2 chunks +1 line, -1 line 0 comments Download
sdk/lib/html/templates/html/impl/impl_Node.darttemplate View 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/html/templates/immutable_list_mixin.darttemplate View 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 9 chunks +54 lines, -54 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 9 chunks +54 lines, -54 lines 0 comments Download
M tools/create_sdk.py View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
blois
8 years ago (2012-11-30 02:49:43 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698