Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 11348313: Revert "Creating a common library for all DOM types." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Oddities with upload. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/native_handler.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 /** 7 /**
8 * If true, print a warning for each method that was resolved, but not 8 * If true, print a warning for each method that was resolved, but not
9 * compiled. 9 * compiled.
10 */ 10 */
(...skipping 470 matching lines...) Expand 10 before | Expand all | Expand 10 after
481 library.addToScope(new ForeignElement( 481 library.addToScope(new ForeignElement(
482 const SourceString('DART_CLOSURE_TO_JS'), library), this); 482 const SourceString('DART_CLOSURE_TO_JS'), library), this);
483 } 483 }
484 484
485 // TODO(karlklose,floitsch): move this to the javascript backend. 485 // TODO(karlklose,floitsch): move this to the javascript backend.
486 /** Enable the 'JS' helper for a library if needed. */ 486 /** Enable the 'JS' helper for a library if needed. */
487 void maybeEnableJSHelper(LibraryElement library) { 487 void maybeEnableJSHelper(LibraryElement library) {
488 String libraryName = library.uri.toString(); 488 String libraryName = library.uri.toString();
489 if (library.entryCompilationUnit.script.name.contains( 489 if (library.entryCompilationUnit.script.name.contains(
490 'dart/tests/compiler/dart2js_native') 490 'dart/tests/compiler/dart2js_native')
491 || libraryName == 'dart:html_common'
492 || libraryName == 'dart:mirrors' 491 || libraryName == 'dart:mirrors'
493 || libraryName == 'dart:isolate' 492 || libraryName == 'dart:isolate'
494 || libraryName == 'dart:math' 493 || libraryName == 'dart:math'
495 || libraryName == 'dart:html' 494 || libraryName == 'dart:html'
496 || libraryName == 'dart:svg' 495 || libraryName == 'dart:svg'
497 || libraryName == 'dart:web_audio') { 496 || libraryName == 'dart:web_audio') {
498 if (libraryName == 'dart:html' || 497 if (libraryName == 'dart:html' || libraryName == 'dart:mirrors') {
499 libraryName == 'dart:html_common' ||
500 libraryName == 'dart:mirrors') {
501 // dart:html needs access to convertDartClosureToJS. 498 // dart:html needs access to convertDartClosureToJS.
502 // dart:mirrors needs access to the Primitives class. 499 // dart:mirrors needs access to the Primitives class.
503 importHelperLibrary(library); 500 importHelperLibrary(library);
504 } 501 }
505 library.addToScope(findHelper(const SourceString('JS')), this); 502 library.addToScope(findHelper(const SourceString('JS')), this);
506 Element jsIndexingBehaviorInterface = 503 Element jsIndexingBehaviorInterface =
507 findHelper(const SourceString('JavaScriptIndexingBehavior')); 504 findHelper(const SourceString('JavaScriptIndexingBehavior'));
508 if (jsIndexingBehaviorInterface != null) { 505 if (jsIndexingBehaviorInterface != null) {
509 library.addToScope(jsIndexingBehaviorInterface, this); 506 library.addToScope(jsIndexingBehaviorInterface, this);
510 } 507 }
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
942 // TODO(johnniwinther): Use [spannable] and [message] to provide better 939 // TODO(johnniwinther): Use [spannable] and [message] to provide better
943 // information on assertion errors. 940 // information on assertion errors.
944 if (condition is Function){ 941 if (condition is Function){
945 condition = condition(); 942 condition = condition();
946 } 943 }
947 if (spannable == null || !condition) { 944 if (spannable == null || !condition) {
948 throw new SpannableAssertionFailure(spannable, message); 945 throw new SpannableAssertionFailure(spannable, message);
949 } 946 }
950 return true; 947 return true;
951 } 948 }
OLDNEW
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/native_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698