Issue 11348289: Attempt to do direct class comparison for type checks using CHA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348289: Attempt to do direct class comparison for type checks using CHA. (Closed)

Created:
8 years ago by srdjan

Modified:
8 years ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Attempt to do direct class comparison for type checks using CHA. Next step is to convert instanceof nodes to an integer comparison node, which would then be automatically merged with branch. Committed: https://code.google.com/p/dart/source/detail?r=15486

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -0 lines)			Patch
M	runtime/vm/flow_graph_compiler.cc	View	1 2 3	3 chunks	+26 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/11348289/diff/2002/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://codereview.chromium.org/11348289/diff/2002/runtime/vm/flow_graph_compiler.cc#newcode1011 runtime/vm/flow_graph_compiler.cc:1011: bool FlowGraphCompiler::TypeCheckAsClassEquality(const AbstractType& type) { ASSERT(type.IsFinalized() && !type.IsMalformed());

8 years ago (2012-11-29 00:28:32 UTC) #2

srdjan

8 years ago (2012-11-29 00:33:36 UTC) #3

https://codereview.chromium.org/11348289/diff/2002/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/11348289/diff/2002/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler.cc:1011: bool
FlowGraphCompiler::TypeCheckAsClassEquality(const AbstractType& type) {
On 2012/11/29 00:28:32, regis wrote:
> ASSERT(type.IsFinalized() && !type.IsMalformed());

Done.

Expand Messages | Collapse Messages