Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 11348289: Attempt to do direct class comparison for type checks using CHA. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.h ('k') | runtime/vm/flow_graph_compiler_x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_ia32.cc
===================================================================
--- runtime/vm/flow_graph_compiler_ia32.cc (revision 15478)
+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)
@@ -392,6 +392,20 @@
// type error. A null value is handled prior to executing this inline code.
return SubtypeTestCache::null();
}
+ if (TypeCheckAsClassEquality(type)) {
+ const intptr_t type_cid = Class::Handle(type.type_class()).id();
+ const Register kInstanceReg = EAX;
+ __ testl(kInstanceReg, Immediate(kSmiTagMask));
+ if (type_cid == kSmiCid) {
+ __ j(ZERO, is_instance_lbl);
+ } else {
+ __ j(ZERO, is_not_instance_lbl);
+ __ CompareClassId(kInstanceReg, type_cid, EDI);
+ __ j(EQUAL, is_instance_lbl);
+ }
+ __ jmp(is_not_instance_lbl);
+ return SubtypeTestCache::null();
+ }
if (type.IsInstantiated()) {
const Class& type_class = Class::ZoneHandle(type.type_class());
// A Smi object cannot be the instance of a parameterized class.
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.h ('k') | runtime/vm/flow_graph_compiler_x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698