Issue 11348288: Get archive creation working on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348288: Get archive creation working on Windows. (Closed)

Created:
8 years ago by Bob Nystrom

Modified:
8 years ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Get archive creation working on Windows. Committed: https://code.google.com/p/dart/source/detail?r=15482

Patch Set 2 : Rebase. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -40 lines)			Patch
M	utils/pub/io.dart	View	1	5 chunks	+25 lines, -11 lines	0 comments	Download
M	utils/pub/utils.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	utils/tests/pub/pub.status	View	1	1 chunk	+0 lines, -19 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/11348288/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/11348288/diff/1/utils/pub/io.dart#newcode380 utils/pub/io.dart:380: utilsDir = utilsDir.directoryPath; We should have a reasonable ...

8 years ago (2012-11-28 23:37:55 UTC) #2

Bob Nystrom

8 years ago (2012-11-29 00:16:11 UTC) #3

https://codereview.chromium.org/11348288/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/11348288/diff/1/utils/pub/io.dart#newcode380
utils/pub/io.dart:380: utilsDir = utilsDir.directoryPath;
On 2012/11/28 23:37:55, nweiz wrote:
> We should have a reasonable error message if this ever stops working.

Yeah, I'm not sure exactly how this will fail, but I would definitely like to do
something more robust. This code will change soon(ish) when pub moves in the
repo. I'll try to do something better then.

Expand Messages | Collapse Messages

Issue 11348288: Get archive creation working on Windows. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebase. #

Messages