Get archive creation working on Windows.

utils/tests/pub/test_pub.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Test infrastructure for testing pub. Unlike typical unit tests, most pub
  * tests are integration tests that stage some stuff on the file system, run
  * pub, and then validate the results. This library provides an API to build
  * tests like that.
  */
@@ skipping 649 matching lines @@
     return isGitInstalled.transform((installed) {
       if (!installed &&
           !Platform.environment.containsKey('BUILDBOT_BUILDERNAME')) {
         _abortScheduled = true;
       }
       return null;
     });
   });
 }
 
-Future<Directory> _setUpSandbox() {
-  return createTempDir();
-}
+Future<Directory> _setUpSandbox() => createTempDir();
 
 Future _runScheduled(Directory parentDir, List<_ScheduledEvent> scheduled) {
   if (scheduled == null) return new Future.immediate(null);
   var iterator = scheduled.iterator();
 
   Future runNextEvent(_) {
     if (_abortScheduled || !iterator.hasNext) {
       _abortScheduled = false;
       scheduled.clear();
       return new Future.immediate(null);
@@ skipping 464 matching lines @@
   final List<Descriptor> contents;
 
   TarFileDescriptor(Pattern name, this.contents)
   : super(name);
 
   /**
    * Creates the files and directories within this tar file, then archives them,
    * compresses them, and saves the result to [parentDir].
    */
   Future<File> create(parentDir) {
+    // TODO(rnystrom): Use withTempDir().
     var tempDir;
-    return parentDir.createTemp().chain((_tempDir) {
+    return createTempDir().chain((_tempDir) {
       tempDir = _tempDir;
       return Futures.wait(contents.map((child) => child.create(tempDir)));
     }).chain((createdContents) {
       return consumeInputStream(createTarGz(createdContents, baseDir: tempDir));
     }).chain((bytes) {
       return new File(join(parentDir, _stringName)).writeAsBytes(bytes);
     }).chain((file) {
       return deleteDir(tempDir).transform((_) => file);
     });
   }
@@ skipping 13 matching lines @@
    * Loads the contents of this tar file.
    */
   InputStream load(List<String> path) {
     if (!path.isEmpty) {
       var joinedPath = Strings.join(path, '/');
       throw "Can't load $joinedPath from within $name: not a directory.";
     }
 
     var sinkStream = new ListInputStream();
     var tempDir;
+    // TODO(rnystrom): Use withTempDir() here.
     // TODO(nweiz): propagate any errors to the return value. See issue 3657.
     createTempDir().chain((_tempDir) {
       tempDir = _tempDir;
       return create(tempDir);
     }).then((tar) {
       var sourceStream = tar.openInputStream();
-      pipeInputToInput(sourceStream,
-                       sinkStream,
-                       () => tempDir.delete(recursive: true));
+      pipeInputToInput(sourceStream, sinkStream).then((_) {
+        tempDir.delete(recursive: true);
+      });
     });
     return sinkStream;
   }
 }
 
 /**
  * A descriptor that validates that no file exists with the given name.
  */
 class NothingDescriptor extends Descriptor {
   NothingDescriptor(String name) : super(name);
@@ skipping 317 matching lines @@
 /// calling [completion] is unnecessary.
 void expectLater(Future actual, matcher, {String reason,
     FailureHandler failureHandler, bool verbose: false}) {
   _schedule((_) {
     return actual.transform((value) {
       expect(value, matcher, reason: reason, failureHandler: failureHandler,
           verbose: false);
     });
   });
 }