Issue 11348285: Work around issue 6984.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348285: Work around issue 6984. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Work around issue 6984. This ensures that before an HTTP response is closed, its corresponding request is drained of input. Committed: https://code.google.com/p/dart/source/detail?r=15476

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -26 lines)			Patch
M	pkg/http/test/utils.dart	View	4 chunks	+12 lines, -3 lines	2 comments	Download
M	utils/pub/io.dart	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	utils/pub/oauth2.dart	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	utils/tests/pub/oauth2_test.dart	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	utils/tests/pub/pub_lish_test.dart	View	12 chunks	+13 lines, -13 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. https://codereview.chromium.org/11348285/diff/1/pkg/http/test/utils.dart File pkg/http/test/utils.dart (right): https://codereview.chromium.org/11348285/diff/1/pkg/http/test/utils.dart#newcode113 pkg/http/test/utils.dart:113: request.inputStream.onClosed = response.outputStream.close; Will it cause any problems ...

8 years ago (2012-11-28 22:41:44 UTC) #2

nweiz

8 years ago (2012-11-28 22:42:41 UTC) #3

https://codereview.chromium.org/11348285/diff/1/pkg/http/test/utils.dart
File pkg/http/test/utils.dart (right):

https://codereview.chromium.org/11348285/diff/1/pkg/http/test/utils.dart#newc...
pkg/http/test/utils.dart:113: request.inputStream.onClosed =
response.outputStream.close;
On 2012/11/28 22:41:44, Bob Nystrom wrote:
> Will it cause any problems that we no longer synchronously close the response?

God, I hope not.

In seriousness, it was all being done in an asynchronous event handler anyway,
so it shouldn't matter.

Expand Messages | Collapse Messages