OLD | NEW |
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file |
2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
4 | 4 |
5 library pub_lish_test; | 5 library pub_lish_test; |
6 | 6 |
7 import 'dart:io'; | 7 import 'dart:io'; |
8 import 'dart:json'; | 8 import 'dart:json'; |
9 | 9 |
10 import 'test_pub.dart'; | 10 import 'test_pub.dart'; |
11 import '../../../pkg/unittest/lib/unittest.dart'; | 11 import '../../../pkg/unittest/lib/unittest.dart'; |
12 import '../../pub/io.dart'; | 12 import '../../pub/io.dart'; |
13 | 13 |
14 void handleUploadForm(ScheduledServer server, [Map body]) { | 14 void handleUploadForm(ScheduledServer server, [Map body]) { |
15 server.handle('GET', '/packages/versions/new.json', (request, response) { | 15 server.handle('GET', '/packages/versions/new.json', (request, response) { |
16 return server.url.transform((url) { | 16 return server.url.chain((url) { |
17 expect(request.headers.value('authorization'), | 17 expect(request.headers.value('authorization'), |
18 equals('Bearer access token')); | 18 equals('Bearer access token')); |
19 | 19 |
20 if (body == null) { | 20 if (body == null) { |
21 body = { | 21 body = { |
22 'url': url.resolve('/upload').toString(), | 22 'url': url.resolve('/upload').toString(), |
23 'fields': { | 23 'fields': { |
24 'field1': 'value1', | 24 'field1': 'value1', |
25 'field2': 'value2' | 25 'field2': 'value2' |
26 } | 26 } |
27 }; | 27 }; |
28 } | 28 } |
29 | 29 |
30 response.headers.contentType = new ContentType("application", "json"); | 30 response.headers.contentType = new ContentType("application", "json"); |
31 response.outputStream.writeString(JSON.stringify(body)); | 31 response.outputStream.writeString(JSON.stringify(body)); |
32 response.outputStream.close(); | 32 return closeHttpResponse(request, response); |
33 }); | 33 }); |
34 }); | 34 }); |
35 } | 35 } |
36 | 36 |
37 void handleUpload(ScheduledServer server) { | 37 void handleUpload(ScheduledServer server) { |
38 server.handle('POST', '/upload', (request, response) { | 38 server.handle('POST', '/upload', (request, response) { |
39 // TODO(nweiz): Once a multipart/form-data parser in Dart exists, validate | 39 // TODO(nweiz): Once a multipart/form-data parser in Dart exists, validate |
40 // that the request body is correctly formatted. See issue 6952. | 40 // that the request body is correctly formatted. See issue 6952. |
41 return server.url.transform((url) { | 41 return server.url.chain((url) { |
42 response.statusCode = 302; | 42 response.statusCode = 302; |
43 response.headers.set('location', url.resolve('/create').toString()); | 43 response.headers.set('location', url.resolve('/create').toString()); |
44 response.outputStream.close(); | 44 return closeHttpResponse(request, response); |
45 }); | 45 }); |
46 }); | 46 }); |
47 } | 47 } |
48 | 48 |
49 main() { | 49 main() { |
50 setUp(() => dir(appPath, [libPubspec("test_pkg", "1.0.0")]).scheduleCreate()); | 50 setUp(() => dir(appPath, [libPubspec("test_pkg", "1.0.0")]).scheduleCreate()); |
51 | 51 |
52 test('archives and uploads a package', () { | 52 test('archives and uploads a package', () { |
53 var server = new ScheduledServer(); | 53 var server = new ScheduledServer(); |
54 credentialsFile(server, 'access token').scheduleCreate(); | 54 credentialsFile(server, 'access token').scheduleCreate(); |
55 var pub = startPubLish(server); | 55 var pub = startPubLish(server); |
56 handleUploadForm(server); | 56 handleUploadForm(server); |
57 handleUpload(server); | 57 handleUpload(server); |
58 | 58 |
59 server.handle('GET', '/create', (request, response) { | 59 server.handle('GET', '/create', (request, response) { |
60 response.outputStream.writeString(JSON.stringify({ | 60 response.outputStream.writeString(JSON.stringify({ |
61 'success': {'message': 'Package test_pkg 1.0.0 uploaded!'} | 61 'success': {'message': 'Package test_pkg 1.0.0 uploaded!'} |
62 })); | 62 })); |
63 response.outputStream.close(); | 63 return closeHttpResponse(request, response); |
64 }); | 64 }); |
65 | 65 |
66 expectLater(pub.nextLine(), equals('Package test_pkg 1.0.0 uploaded!')); | 66 expectLater(pub.nextLine(), equals('Package test_pkg 1.0.0 uploaded!')); |
67 pub.shouldExit(0); | 67 pub.shouldExit(0); |
68 | 68 |
69 run(); | 69 run(); |
70 }); | 70 }); |
71 | 71 |
72 // TODO(nweiz): Once a multipart/form-data parser in Dart exists, we should | 72 // TODO(nweiz): Once a multipart/form-data parser in Dart exists, we should |
73 // test that "pub lish" chooses the correct files to publish. | 73 // test that "pub lish" chooses the correct files to publish. |
74 | 74 |
75 // TODO(nweiz): Once issue 6813 is fixed, test that OAuth2 authentication | 75 // TODO(nweiz): Once issue 6813 is fixed, test that OAuth2 authentication |
76 // errors cause the client to try re-authenticating. | 76 // errors cause the client to try re-authenticating. |
77 | 77 |
78 test('upload form provides an error', () { | 78 test('upload form provides an error', () { |
79 var server = new ScheduledServer(); | 79 var server = new ScheduledServer(); |
80 credentialsFile(server, 'access token').scheduleCreate(); | 80 credentialsFile(server, 'access token').scheduleCreate(); |
81 var pub = startPubLish(server); | 81 var pub = startPubLish(server); |
82 | 82 |
83 server.handle('GET', '/packages/versions/new.json', (request, response) { | 83 server.handle('GET', '/packages/versions/new.json', (request, response) { |
84 response.statusCode = 400; | 84 response.statusCode = 400; |
85 response.outputStream.writeString(JSON.stringify({ | 85 response.outputStream.writeString(JSON.stringify({ |
86 'error': {'message': 'your request sucked'} | 86 'error': {'message': 'your request sucked'} |
87 })); | 87 })); |
88 response.outputStream.close(); | 88 return closeHttpResponse(request, response); |
89 }); | 89 }); |
90 | 90 |
91 expectLater(pub.nextErrLine(), equals('your request sucked')); | 91 expectLater(pub.nextErrLine(), equals('your request sucked')); |
92 pub.shouldExit(1); | 92 pub.shouldExit(1); |
93 | 93 |
94 run(); | 94 run(); |
95 }); | 95 }); |
96 | 96 |
97 test('upload form provides invalid JSON', () { | 97 test('upload form provides invalid JSON', () { |
98 var server = new ScheduledServer(); | 98 var server = new ScheduledServer(); |
99 credentialsFile(server, 'access token').scheduleCreate(); | 99 credentialsFile(server, 'access token').scheduleCreate(); |
100 var pub = startPubLish(server); | 100 var pub = startPubLish(server); |
101 | 101 |
102 server.handle('GET', '/packages/versions/new.json', (request, response) { | 102 server.handle('GET', '/packages/versions/new.json', (request, response) { |
103 response.outputStream.writeString('{not json'); | 103 response.outputStream.writeString('{not json'); |
104 response.outputStream.close(); | 104 return closeHttpResponse(request, response); |
105 }); | 105 }); |
106 | 106 |
107 expectLater(pub.nextErrLine(), equals('Invalid server response:')); | 107 expectLater(pub.nextErrLine(), equals('Invalid server response:')); |
108 expectLater(pub.nextErrLine(), equals('{not json')); | 108 expectLater(pub.nextErrLine(), equals('{not json')); |
109 pub.shouldExit(1); | 109 pub.shouldExit(1); |
110 | 110 |
111 run(); | 111 run(); |
112 }); | 112 }); |
113 | 113 |
114 test('upload form is missing url', () { | 114 test('upload form is missing url', () { |
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
201 var server = new ScheduledServer(); | 201 var server = new ScheduledServer(); |
202 credentialsFile(server, 'access token').scheduleCreate(); | 202 credentialsFile(server, 'access token').scheduleCreate(); |
203 var pub = startPubLish(server); | 203 var pub = startPubLish(server); |
204 handleUploadForm(server); | 204 handleUploadForm(server); |
205 | 205 |
206 server.handle('POST', '/upload', (request, response) { | 206 server.handle('POST', '/upload', (request, response) { |
207 response.statusCode = 400; | 207 response.statusCode = 400; |
208 response.headers.contentType = new ContentType('application', 'xml'); | 208 response.headers.contentType = new ContentType('application', 'xml'); |
209 response.outputStream.writeString('<Error><Message>Your request sucked.' | 209 response.outputStream.writeString('<Error><Message>Your request sucked.' |
210 '</Message></Error>'); | 210 '</Message></Error>'); |
211 response.outputStream.close(); | 211 return closeHttpResponse(request, response); |
212 }); | 212 }); |
213 | 213 |
214 // TODO(nweiz): This should use the server's error message once the client | 214 // TODO(nweiz): This should use the server's error message once the client |
215 // can parse the XML. | 215 // can parse the XML. |
216 expectLater(pub.nextErrLine(), equals('Failed to upload the package.')); | 216 expectLater(pub.nextErrLine(), equals('Failed to upload the package.')); |
217 pub.shouldExit(1); | 217 pub.shouldExit(1); |
218 | 218 |
219 run(); | 219 run(); |
220 }); | 220 }); |
221 | 221 |
222 test("cloud storage upload doesn't redirect", () { | 222 test("cloud storage upload doesn't redirect", () { |
223 var server = new ScheduledServer(); | 223 var server = new ScheduledServer(); |
224 credentialsFile(server, 'access token').scheduleCreate(); | 224 credentialsFile(server, 'access token').scheduleCreate(); |
225 var pub = startPubLish(server); | 225 var pub = startPubLish(server); |
226 handleUploadForm(server); | 226 handleUploadForm(server); |
227 | 227 |
228 server.handle('POST', '/upload', (request, response) { | 228 server.handle('POST', '/upload', (request, response) { |
229 // don't set the location header | 229 // don't set the location header |
230 response.outputStream.close(); | 230 return closeHttpResponse(request, response); |
231 }); | 231 }); |
232 | 232 |
233 expectLater(pub.nextErrLine(), equals('Failed to upload the package.')); | 233 expectLater(pub.nextErrLine(), equals('Failed to upload the package.')); |
234 pub.shouldExit(1); | 234 pub.shouldExit(1); |
235 | 235 |
236 run(); | 236 run(); |
237 }); | 237 }); |
238 | 238 |
239 test('package creation provides an error', () { | 239 test('package creation provides an error', () { |
240 var server = new ScheduledServer(); | 240 var server = new ScheduledServer(); |
241 credentialsFile(server, 'access token').scheduleCreate(); | 241 credentialsFile(server, 'access token').scheduleCreate(); |
242 var pub = startPubLish(server); | 242 var pub = startPubLish(server); |
243 handleUploadForm(server); | 243 handleUploadForm(server); |
244 handleUpload(server); | 244 handleUpload(server); |
245 | 245 |
246 server.handle('GET', '/create', (request, response) { | 246 server.handle('GET', '/create', (request, response) { |
247 response.outputStream.writeString(JSON.stringify({ | 247 response.outputStream.writeString(JSON.stringify({ |
248 'error': {'message': 'Your package was too boring.'} | 248 'error': {'message': 'Your package was too boring.'} |
249 })); | 249 })); |
250 response.outputStream.close(); | 250 return closeHttpResponse(request, response); |
251 }); | 251 }); |
252 | 252 |
253 expectLater(pub.nextErrLine(), equals('Your package was too boring.')); | 253 expectLater(pub.nextErrLine(), equals('Your package was too boring.')); |
254 pub.shouldExit(1); | 254 pub.shouldExit(1); |
255 | 255 |
256 run(); | 256 run(); |
257 }); | 257 }); |
258 | 258 |
259 test('package creation provides invalid JSON', () { | 259 test('package creation provides invalid JSON', () { |
260 var server = new ScheduledServer(); | 260 var server = new ScheduledServer(); |
261 credentialsFile(server, 'access token').scheduleCreate(); | 261 credentialsFile(server, 'access token').scheduleCreate(); |
262 var pub = startPubLish(server); | 262 var pub = startPubLish(server); |
263 handleUploadForm(server); | 263 handleUploadForm(server); |
264 handleUpload(server); | 264 handleUpload(server); |
265 | 265 |
266 server.handle('GET', '/create', (request, response) { | 266 server.handle('GET', '/create', (request, response) { |
267 response.outputStream.writeString('{not json'); | 267 response.outputStream.writeString('{not json'); |
268 response.outputStream.close(); | 268 return closeHttpResponse(request, response); |
269 }); | 269 }); |
270 | 270 |
271 expectLater(pub.nextErrLine(), equals('Invalid server response:')); | 271 expectLater(pub.nextErrLine(), equals('Invalid server response:')); |
272 expectLater(pub.nextErrLine(), equals('{not json')); | 272 expectLater(pub.nextErrLine(), equals('{not json')); |
273 pub.shouldExit(1); | 273 pub.shouldExit(1); |
274 | 274 |
275 run(); | 275 run(); |
276 }); | 276 }); |
277 | 277 |
278 test('package creation provides a malformed error', () { | 278 test('package creation provides a malformed error', () { |
279 var server = new ScheduledServer(); | 279 var server = new ScheduledServer(); |
280 credentialsFile(server, 'access token').scheduleCreate(); | 280 credentialsFile(server, 'access token').scheduleCreate(); |
281 var pub = startPubLish(server); | 281 var pub = startPubLish(server); |
282 handleUploadForm(server); | 282 handleUploadForm(server); |
283 handleUpload(server); | 283 handleUpload(server); |
284 | 284 |
285 var body = {'error': 'Your package was too boring.'}; | 285 var body = {'error': 'Your package was too boring.'}; |
286 server.handle('GET', '/create', (request, response) { | 286 server.handle('GET', '/create', (request, response) { |
287 response.statusCode = 400; | 287 response.statusCode = 400; |
288 response.outputStream.writeString(JSON.stringify(body)); | 288 response.outputStream.writeString(JSON.stringify(body)); |
289 response.outputStream.close(); | 289 return closeHttpResponse(request, response); |
290 }); | 290 }); |
291 | 291 |
292 expectLater(pub.nextErrLine(), equals('Invalid server response:')); | 292 expectLater(pub.nextErrLine(), equals('Invalid server response:')); |
293 expectLater(pub.nextErrLine(), equals(JSON.stringify(body))); | 293 expectLater(pub.nextErrLine(), equals(JSON.stringify(body))); |
294 pub.shouldExit(1); | 294 pub.shouldExit(1); |
295 | 295 |
296 run(); | 296 run(); |
297 }); | 297 }); |
298 | 298 |
299 test('package creation provides a malformed success', () { | 299 test('package creation provides a malformed success', () { |
300 var server = new ScheduledServer(); | 300 var server = new ScheduledServer(); |
301 credentialsFile(server, 'access token').scheduleCreate(); | 301 credentialsFile(server, 'access token').scheduleCreate(); |
302 var pub = startPubLish(server); | 302 var pub = startPubLish(server); |
303 handleUploadForm(server); | 303 handleUploadForm(server); |
304 handleUpload(server); | 304 handleUpload(server); |
305 | 305 |
306 var body = {'success': 'Your package was awesome.'}; | 306 var body = {'success': 'Your package was awesome.'}; |
307 server.handle('GET', '/create', (request, response) { | 307 server.handle('GET', '/create', (request, response) { |
308 response.outputStream.writeString(JSON.stringify(body)); | 308 response.outputStream.writeString(JSON.stringify(body)); |
309 response.outputStream.close(); | 309 return closeHttpResponse(request, response); |
310 }); | 310 }); |
311 | 311 |
312 expectLater(pub.nextErrLine(), equals('Invalid server response:')); | 312 expectLater(pub.nextErrLine(), equals('Invalid server response:')); |
313 expectLater(pub.nextErrLine(), equals(JSON.stringify(body))); | 313 expectLater(pub.nextErrLine(), equals(JSON.stringify(body))); |
314 pub.shouldExit(1); | 314 pub.shouldExit(1); |
315 | 315 |
316 run(); | 316 run(); |
317 }); | 317 }); |
318 } | 318 } |
OLD | NEW |