Issue 11348207: Fix runtimeType for List and bool.

Issue 11348207: Fix runtimeType for List and bool. (Closed)

Created:
8 years, 1 month ago by karlklose

Modified:
8 years, 1 month ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix runtimeType for List and bool. The type arguments were lost in when merging with the new interceptor style. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=15277

Patch Set 3 : Add a test. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -21 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/lib/interceptors.dart	View	1	1 chunk	+1 line, -20 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_array.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/language/first_class_types_test.dart	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/11348207/diff/1004/tests/language/first_class_types_test.dart File tests/language/first_class_types_test.dart (right): https://codereview.chromium.org/11348207/diff/1004/tests/language/first_class_types_test.dart#newcode40 tests/language/first_class_types_test.dart:40: differentType(new List<int>(), new List()); How about sameType(new List<int>(), ...

8 years, 1 month ago (2012-11-23 08:58:05 UTC) #2

ahe

LGTM https://codereview.chromium.org/11348207/diff/1004/sdk/lib/_internal/compiler/implementation/lib/interceptors.dart File sdk/lib/_internal/compiler/implementation/lib/interceptors.dart (right): https://codereview.chromium.org/11348207/diff/1004/sdk/lib/_internal/compiler/implementation/lib/interceptors.dart#newcode51 sdk/lib/_internal/compiler/implementation/lib/interceptors.dart:51: class JSBool implements bool { Shouldn't this class ...

8 years, 1 month ago (2012-11-23 09:35:16 UTC) #3

karlklose

8 years, 1 month ago (2012-11-23 10:02:41 UTC) #4

Message was sent while issue was closed.

Thanks, Nicolas.

https://codereview.chromium.org/11348207/diff/1004/tests/language/first_class...
File tests/language/first_class_types_test.dart (right):

https://codereview.chromium.org/11348207/diff/1004/tests/language/first_class...
tests/language/first_class_types_test.dart:40: differentType(new List<int>(),
new List());
On 2012/11/23 08:58:05, ngeoffray wrote:
> How about sameType(new List<int>(), new List<int>()); ?

Done.

Expand Messages | Collapse Messages